From: Changli Gao <xiaosuo@gmail.com>
To: Tom Herbert <therbert@google.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] rps: fixed missed rps_unlock
Date: Tue, 6 Apr 2010 06:23:57 +0800 [thread overview]
Message-ID: <z2m412e6f7f1004051523p6198556ak3e2ab9a52a3167d4@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.1004051426140.22393@pokey.mtv.corp.google.com>
On Tue, Apr 6, 2010 at 5:30 AM, Tom Herbert <therbert@google.com> wrote:
> Fix spin_unlock_irq which needs to be rps_unlock.
>
> Signed-off-by: Tom Herbert <therbert@google.com>
> ---
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 2a9b7dd..74f77ca 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -3120,7 +3120,7 @@ static int process_backlog(struct napi_struct *napi, int quota)
> skb = __skb_dequeue(&queue->input_pkt_queue);
> if (!skb) {
> __napi_complete(napi);
> - spin_unlock_irq(&queue->input_pkt_queue.lock);
> + rps_unlock(queue);
> break;
> }
> rps_unlock(queue);
It seems that irq isn't enabled when breaking the loop. Please add
local_irq_enable();
after rps_unlock(queue);
--
Regards，
Changli Gao(xiaosuo@gmail.com)
next prev parent reply other threads:[~2010-04-05 22:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 21:30 [PATCH] rps: fixed missed rps_unlock Tom Herbert
2010-04-05 21:35 ` Eric Dumazet
2010-04-05 21:40 ` Tom Herbert
2010-04-05 21:37 ` David Miller
2010-04-05 22:23 ` Changli Gao [this message]
2010-04-05 22:41 ` [PATCH net-next-2.6] net: Add a missing local_irq_enable() Eric Dumazet
2010-04-05 22:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=z2m412e6f7f1004051523p6198556ak3e2ab9a52a3167d4@mail.gmail.com \
--to=xiaosuo@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).