netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [syzbot] KASAN: use-after-free Read in check_all_holdout_tasks_trace
       [not found] <000000000000f034fc05c2da6617@google.com>
@ 2021-06-19 16:54 ` syzbot
  2021-06-21 22:41   ` Paul E. McKenney
  0 siblings, 1 reply; 3+ messages in thread
From: syzbot @ 2021-06-19 16:54 UTC (permalink / raw)
  To: akpm, andrii, ast, axboe, bpf, christian, coreteam, daniel, davem,
	dsahern, dvyukov, fw, jiangshanlai, joel, john.fastabend, josh,
	kadlec, kafai, kpsingh, kuba, linux-kernel, mathieu.desnoyers,
	netdev, netfilter-devel, pablo, paulmck, peterz, rcu, rostedt,
	shakeelb, songliubraving, syzkaller-bugs, yanfei.xu, yhs,
	yoshfuji

syzbot has bisected this issue to:

commit f9006acc8dfe59e25aa75729728ac57a8d84fc32
Author: Florian Westphal <fw@strlen.de>
Date:   Wed Apr 21 07:51:08 2021 +0000

    netfilter: arp_tables: pass table pointer via nf_hook_ops

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=10dceae8300000
start commit:   0c38740c selftests/bpf: Fix ringbuf test fetching map FD
git tree:       bpf-next
final oops:     https://syzkaller.appspot.com/x/report.txt?x=12dceae8300000
console output: https://syzkaller.appspot.com/x/log.txt?x=14dceae8300000
kernel config:  https://syzkaller.appspot.com/x/.config?x=a6380da8984033f1
dashboard link: https://syzkaller.appspot.com/bug?extid=7b2b13f4943374609532
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1264c2d7d00000

Reported-by: syzbot+7b2b13f4943374609532@syzkaller.appspotmail.com
Fixes: f9006acc8dfe ("netfilter: arp_tables: pass table pointer via nf_hook_ops")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [syzbot] KASAN: use-after-free Read in check_all_holdout_tasks_trace
  2021-06-19 16:54 ` [syzbot] KASAN: use-after-free Read in check_all_holdout_tasks_trace syzbot
@ 2021-06-21 22:41   ` Paul E. McKenney
  2021-06-28  8:43     ` Dmitry Vyukov
  0 siblings, 1 reply; 3+ messages in thread
From: Paul E. McKenney @ 2021-06-21 22:41 UTC (permalink / raw)
  To: syzbot
  Cc: akpm, andrii, ast, axboe, bpf, christian, coreteam, daniel, davem,
	dsahern, dvyukov, fw, jiangshanlai, joel, john.fastabend, josh,
	kadlec, kafai, kpsingh, kuba, linux-kernel, mathieu.desnoyers,
	netdev, netfilter-devel, pablo, peterz, rcu, rostedt, shakeelb,
	songliubraving, syzkaller-bugs, yanfei.xu, yhs, yoshfuji

On Sat, Jun 19, 2021 at 09:54:06AM -0700, syzbot wrote:
> syzbot has bisected this issue to:
> 
> commit f9006acc8dfe59e25aa75729728ac57a8d84fc32
> Author: Florian Westphal <fw@strlen.de>
> Date:   Wed Apr 21 07:51:08 2021 +0000
> 
>     netfilter: arp_tables: pass table pointer via nf_hook_ops
> 
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=10dceae8300000
> start commit:   0c38740c selftests/bpf: Fix ringbuf test fetching map FD
> git tree:       bpf-next
> final oops:     https://syzkaller.appspot.com/x/report.txt?x=12dceae8300000
> console output: https://syzkaller.appspot.com/x/log.txt?x=14dceae8300000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=a6380da8984033f1
> dashboard link: https://syzkaller.appspot.com/bug?extid=7b2b13f4943374609532
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1264c2d7d00000
> 
> Reported-by: syzbot+7b2b13f4943374609532@syzkaller.appspotmail.com
> Fixes: f9006acc8dfe ("netfilter: arp_tables: pass table pointer via nf_hook_ops")
> 
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection

I am not seeing any mention of check_all_holdout_tasks_trace() in
the console output, but I again suggest the following two patches:

6a04a59eacbd ("rcu-tasks: Don't delete holdouts within trc_inspect_reader()"
dd5da0a9140e ("rcu-tasks: Don't delete holdouts within trc_wait_for_one_reader()")

							Thanx, Paul

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [syzbot] KASAN: use-after-free Read in check_all_holdout_tasks_trace
  2021-06-21 22:41   ` Paul E. McKenney
@ 2021-06-28  8:43     ` Dmitry Vyukov
  0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Vyukov @ 2021-06-28  8:43 UTC (permalink / raw)
  To: paulmck
  Cc: syzbot, akpm, andrii, ast, axboe, bpf, christian, coreteam,
	daniel, davem, dsahern, fw, jiangshanlai, joel, john.fastabend,
	josh, kadlec, kafai, kpsingh, kuba, linux-kernel,
	mathieu.desnoyers, netdev, netfilter-devel, pablo, peterz, rcu,
	rostedt, shakeelb, songliubraving, syzkaller-bugs, yanfei.xu, yhs,
	yoshfuji

On Tue, Jun 22, 2021 at 12:41 AM Paul E. McKenney <paulmck@kernel.org> wrote:
>
> On Sat, Jun 19, 2021 at 09:54:06AM -0700, syzbot wrote:
> > syzbot has bisected this issue to:
> >
> > commit f9006acc8dfe59e25aa75729728ac57a8d84fc32
> > Author: Florian Westphal <fw@strlen.de>
> > Date:   Wed Apr 21 07:51:08 2021 +0000
> >
> >     netfilter: arp_tables: pass table pointer via nf_hook_ops
> >
> > bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=10dceae8300000
> > start commit:   0c38740c selftests/bpf: Fix ringbuf test fetching map FD
> > git tree:       bpf-next
> > final oops:     https://syzkaller.appspot.com/x/report.txt?x=12dceae8300000
> > console output: https://syzkaller.appspot.com/x/log.txt?x=14dceae8300000
> > kernel config:  https://syzkaller.appspot.com/x/.config?x=a6380da8984033f1
> > dashboard link: https://syzkaller.appspot.com/bug?extid=7b2b13f4943374609532
> > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1264c2d7d00000
> >
> > Reported-by: syzbot+7b2b13f4943374609532@syzkaller.appspotmail.com
> > Fixes: f9006acc8dfe ("netfilter: arp_tables: pass table pointer via nf_hook_ops")
> >
> > For information about bisection process see: https://goo.gl/tpsmEJ#bisection
>
> I am not seeing any mention of check_all_holdout_tasks_trace() in
> the console output, but I again suggest the following two patches:
>
> 6a04a59eacbd ("rcu-tasks: Don't delete holdouts within trc_inspect_reader()"
> dd5da0a9140e ("rcu-tasks: Don't delete holdouts within trc_wait_for_one_reader()")

Let's tell syzbot about these fixes, then it will tell us if they help or not.

#syz fix: rcu-tasks: Don't delete holdouts within trc_inspect_reader()

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-28  8:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <000000000000f034fc05c2da6617@google.com>
2021-06-19 16:54 ` [syzbot] KASAN: use-after-free Read in check_all_holdout_tasks_trace syzbot
2021-06-21 22:41   ` Paul E. McKenney
2021-06-28  8:43     ` Dmitry Vyukov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).