netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Gao Feng" <gfree.wind@foxmail.com>
To: "'Liping Zhang'" <zlpnobody@gmail.com>,
	"'Pablo Neira Ayuso'" <pablo@netfilter.org>
Cc: "'Liping Zhang'" <zlpnobody@163.com>,
	"'Netfilter Developer Mailing List'"
	<netfilter-devel@vger.kernel.org>
Subject: RE: [PATCH nf] netfilter: xt_CT: fix cthelper module's refcnt leak
Date: Fri, 14 Apr 2017 08:49:33 +0800	[thread overview]
Message-ID: <000101d2b4b8$fc4220a0$f4c661e0$@foxmail.com> (raw)
In-Reply-To: <CAML_gOe-gAk0fyhRE9e4chqL7=nEOqc5_cWBO0YvqAAKqZXHSw@mail.gmail.com>

> -----Original Message-----
> From: Liping Zhang [mailto:zlpnobody@gmail.com]
> Hi Pablo,
> 
> 2017-04-14 6:30 GMT+08:00 Pablo Neira Ayuso <pablo@netfilter.org>:
> >> We should call module_put when the time policy is not found.
> >> Otherwise, the related cthelper module cannot be removed anymore.
> >>
> >> It is easy to reproduce by typing the following command:
> >>   # iptables -t raw -A OUTPUT -p tcp -j CT --helper ftp --timeout xxx
> >
> > Can we fix all leaks in the error path in one single patch for xt_CT?
> 
> Right.
> 
> > Feng sent me a patch to fix another issue there, so if either you or
> > him send me one single patch to fix all xt_CT refcount leaks in one
> > go, I'd appreciate.
> 
> Feng, since you spotted this issue earlier, can you send a new patch to do this?
> With a new patch name: "netfilter: xt_CT: fix refcnt leak on error path".

Thanks.

> 
> Also you can add my:
> Signed-off-by: Liping Zhang <zlpnobody@gmail.com>

No problem.

Regards
Feng




      reply	other threads:[~2017-04-14  0:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-08  3:38 [PATCH nf] netfilter: xt_CT: fix cthelper module's refcnt leak Liping Zhang
2017-04-13 22:30 ` Pablo Neira Ayuso
2017-04-13 23:09   ` Liping Zhang
2017-04-14  0:49     ` Gao Feng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000101d2b4b8$fc4220a0$f4c661e0$@foxmail.com' \
    --to=gfree.wind@foxmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=zlpnobody@163.com \
    --cc=zlpnobody@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).