From: Thomas Haller <thaller@redhat.com>
To: Phil Sutter <phil@nwl.cc>, Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] tests: shell: Fix sets/reset_command_0 for current kernels
Date: Thu, 02 Nov 2023 16:29:34 +0100 [thread overview]
Message-ID: <08a7ddd943c17548bbe4a72d6c0aae3110b0d39e.camel@redhat.com> (raw)
In-Reply-To: <20231102150342.3543-1-phil@nwl.cc>
On Thu, 2023-11-02 at 16:03 +0100, Phil Sutter wrote:
>
> +# Note: Element expiry is no longer reset since kernel commit
> 4c90bba60c26
> +# ("netfilter: nf_tables: do not refresh timeout when resetting
> element"),
> +# the respective parts of the test have therefore been commented
> out.
Hi Phil,
do you expect that the old behavior ever comes back?
Why keep the old checks (commented out)? Maybe drop them? We can get it
from git history.
If you think something is still unclear without them, then instead
elaborate further in the code comment (thanks for adding a code comment
in the first place, very useful).
Thomas
next prev parent reply other threads:[~2023-11-02 15:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 15:03 [nft PATCH] tests: shell: Fix sets/reset_command_0 for current kernels Phil Sutter
2023-11-02 15:29 ` Thomas Haller [this message]
2023-11-02 17:06 ` Phil Sutter
2023-11-02 20:32 ` Pablo Neira Ayuso
2023-11-05 18:35 ` Pablo Neira Ayuso
2023-11-07 10:38 ` Phil Sutter
2023-11-22 11:30 ` Pablo Neira Ayuso
2023-11-22 13:35 ` Phil Sutter
2023-11-22 17:50 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08a7ddd943c17548bbe4a72d6c0aae3110b0d39e.camel@redhat.com \
--to=thaller@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).