From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart De Schuymer Subject: Re: Fw: Problems with nf_nat_ftp.ko and nf_conntrack_ftp.ko in 2.6.22.6 Date: Thu, 08 Nov 2007 00:29:51 +0100 Message-ID: <1194478191.2983.7.camel@localhost.localdomain> References: <4731A7A9.1050606@trash.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "bdschuym@pandora.be" , ron lai , netfilter@vger.kernel.org, netfilter-devel@vger.kernel.org To: Patrick McHardy Return-path: Received: from dike.telenet-ops.be ([195.130.132.36]:39774 "EHLO dike.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752663AbXKHDLT (ORCPT ); Wed, 7 Nov 2007 22:11:19 -0500 In-Reply-To: <4731A7A9.1050606@trash.net> Sender: netfilter-devel-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org Op wo, 07-11-2007 te 12:55 +0100, schreef Patrick McHardy: > Could you check the attached patch? Looks ok to me. > > Another solution I think is this: > > in br_nf_post_routing(): > > change > > if (!nf_bridge) > > to > > if (!nf_bridge || !(nf_bridge->mask & BRNF_BRIDGED_DNAT)) > > Wouldn't that break the regular case of packets forwarded > through a single bridge? Hmm, yes, we'd need to or it with BRNF_BRIDGED. I personally prefer something like that, leaving the call to nf_bridge_put when the skbuff is removed. But it's your call :) cheers, Bart