From: Jesper Dangaard Brouer <jdb@comx.dk>
To: Thomas Jacob <jacob@internet24.de>
Cc: netfilter-devel@vger.kernel.org,
Patrick McHardy <kaber@trash.net>,
Jesper Dangaard Brouer <jdb@comx.dk>
Subject: Patches solving the same issue!?
Date: Wed, 02 Jul 2008 22:57:31 +0200 [thread overview]
Message-ID: <1215032251.9467.11.camel@localhost.localdomain> (raw)
In-Reply-To: <1215021635-28691-2-git-send-email-jacob@internet24.de>
I can see from the list that Thomas Jacob <jacob@internet24.de>, and I
have just posted patches solving the same issue.
I promised Patrick that I would work on this issue, and I did.
Its running on our production servers, and I planned to release the
patch today as it has proven stable on production. I guess Thomas was
just slightly faster than me ;-)
It was actually already released in the CPAN module IPTables::libiptc
(ver.0.08 released 2008-06-16).
We both use binary search, but with two slightly different approaches.
- My patch uses the existing data structure, and the existing
algorithm for binary searching.
- Thomas builds a new data structure and implements a new binary
search algorithm.
I must give Thomas that this binary search algo (taken from wikipedia)
is much more compact than the existing one.
Guess I cannot judge what patch is the best, as I'm biased...
next prev parent reply other threads:[~2008-07-02 20:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-02 18:00 [PATCH 0/3] Further speedup of iptables when modifying an existing ruleset Thomas Jacob
2008-07-02 18:00 ` [PATCH 1/3] Speed up verdict to chain_head mapping by using binary search Thomas Jacob
2008-07-02 18:00 ` [PATCH 2/3] Spelling Thomas Jacob
2008-07-02 18:00 ` [PATCH 3/3] Coding style Thomas Jacob
2008-07-02 20:57 ` Jesper Dangaard Brouer [this message]
2008-07-02 21:47 ` Patches solving the same issue!? Thomas Jacob
2008-07-02 22:02 ` Thomas Jacob
2008-07-03 10:53 ` Jesper Dangaard Brouer
2008-07-03 11:17 ` Thomas Jacob
2008-07-03 12:42 ` Patrick McHardy
2008-07-03 14:30 ` Thomas Jacob
2008-07-03 14:33 ` Patrick McHardy
2008-07-04 7:09 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215032251.9467.11.camel@localhost.localdomain \
--to=jdb@comx.dk \
--cc=jacob@internet24.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox