[libnetfilter_log patch] Fix minor memory leak.

[libnetfilter_log patch] Fix minor memory leak.

[Eric Leblond]

The nflog_handle is allocated in nflog_open(). This patch adds the missing
free in nlog_close().

Signed-off-by: Eric Leblond <eric@inl.fr>
---
 src/libnetfilter_log.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/libnetfilter_log.c b/src/libnetfilter_log.c
index 6c0936e..216cdb8 100644
--- a/src/libnetfilter_log.c
+++ b/src/libnetfilter_log.c
@@ -237,7 +237,9 @@ int nflog_handle_packet(struct nflog_handle *h, char *buf, int len)
 
 int nflog_close(struct nflog_handle *h)
 {
-	return nfnl_close(h->nfnlh);
+	int ret = nfnl_close(h->nfnlh);
+	free(h);
+	return ret;
 }
 
 /* bind nf_queue from a specific protocol family */
-- 
1.5.6.3

Re: [libnetfilter_log patch] Fix minor memory leak.

[Eric Leblond]

[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

Hi,

This patch has been applied to libnetfilter_log git tree.

Le dimanche 30 novembre 2008 à 15:34 +0100, Eric Leblond a écrit :
> The nflog_handle is allocated in nflog_open(). This patch adds the missing
> free in nflog_close().
> 
> Signed-off-by: Eric Leblond <eric@inl.fr>
> ---
>  src/libnetfilter_log.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/src/libnetfilter_log.c b/src/libnetfilter_log.c
> index 6c0936e..216cdb8 100644
> --- a/src/libnetfilter_log.c
> +++ b/src/libnetfilter_log.c
> @@ -237,7 +237,9 @@ int nflog_handle_packet(struct nflog_handle *h, char *buf, int len)
>  
>  int nflog_close(struct nflog_handle *h)
>  {
> -	return nfnl_close(h->nfnlh);
> +	int ret = nfnl_close(h->nfnlh);
> +	free(h);
> +	return ret;
>  }
>  
>  /* bind nf_queue from a specific protocol family */

BR,
-- 
Éric Leblond <eric@inl.fr>
INL, http://www.inl.fr/
NuFW, http://www.nufw.org

[-- Attachment #2: Ceci est une partie de message numériquement signée --]
[-- Type: application/pgp-signature, Size: 197 bytes --]