From: Eric Leblond <eric@inl.fr>
To: netfilter-devel@vger.kernel.org
Cc: pablo@netfilter.org
Subject: [ULOGD2 PATCH 0/18] Code cleaning, SCTP support, NFLOG logic fix
Date: Mon, 1 Dec 2008 22:35:58 +0100 [thread overview]
Message-ID: <1228167376-22101-1-git-send-email-eric@inl.fr> (raw)
Hi,
This patchset is made of four parts.
First part is Pablo's work that I have completed. It cleans up
the current key assignation by introducing a new set of functions:
* add ukey_* function for key assignation
Second part fixes a logic problem in NFLOG input plugin. System logging
(for instance invalid conntrack message) are done on group 0 queue for
all protocols. Thus a protocol dependant NFLOG plugin is stupid.
Furthermore, the nfnetlink message contains the protocol information. This
set of patch suppresses the addressfamily variable and modify NFLOG to
only bind as system logging if group is 0:
* Modify usage of nflog_bind_pf function.
* Get rid of addressfamily variable in NFLOG input plugin
* Document group 0 usage and suppress address_family
Third part adds support for SCTP in ulogd2. It contains a basic packet
parser and a support in all OUTPUT plugin:
* Add SCTP support to BASE plugin.
* SCTP support for PRINTPKT.
* Add SCTP support to MySQL and PGSQL output.
Last part is code cleaning. It fixes some memory leak fixes and cleaning
of ulogd exit code.F or example, fini function were defined for each module
but were never called:
* Treat nice function return.
* Fix stop function of NFCT plugin.
* Don't free pluginstance when leaving
* Fix minor memory leak in NFLOG plugin.
* Call pluginstance stop function when exiting
* Add SIGINT to list of terminal signal.
* Unload plugins when quitting.
* Introduce config_stop() function
* Free stacks when exiting.
* Fix memory leak in destructor_nfct().
* Add valgrind compilation option.
This patch is build upon Pierre's last patchset.
Patchset statistics:
doc/mysql-ulogd2.sql | 43 ++++-
doc/pgsql-ulogd2.sql | 41 ++++-
filter/raw2packet/ulogd_raw2packet_BASE.c | 270 +++++++++++++--------------
filter/raw2packet/ulogd_raw2packet_LOCAL.c | 7 +-
filter/ulogd_filter_HWHDR.c | 76 ++++----
filter/ulogd_filter_IFINDEX.c | 30 ++--
filter/ulogd_filter_IP2BIN.c | 9 +-
filter/ulogd_filter_IP2STR.c | 15 +-
filter/ulogd_filter_MARK.c | 4 +-
filter/ulogd_filter_PRINTFLOW.c | 3 +-
filter/ulogd_filter_PRINTPKT.c | 3 +-
filter/ulogd_filter_PWSNIFF.c | 27 ++--
include/ulogd/conffile.h | 3 +
include/ulogd/printpkt.h | 2 +
include/ulogd/ulogd.h | 68 +++++++-
input/flow/ulogd_inpflow_NFCT.c | 171 +++++++-----------
input/packet/ulogd_inppkt_NFLOG.c | 186 +++++++++-----------
input/packet/ulogd_inppkt_ULOG.c | 46 ++----
output/pcap/ulogd_output_PCAP.c | 11 +-
output/ulogd_output_NACCT.c | 34 ++--
src/conffile.c | 4 +
src/hash.c | 6 +-
src/ulogd.c | 76 ++++++++-
ulogd.conf.in | 37 ++--
util/printflow.c | 52 +++---
util/printpkt.c | 163 +++++++++--------
26 files changed, 768 insertions(+), 619 deletions(-)
BR,
--
Eric Leblond <eric@inl.fr>
next reply other threads:[~2008-12-01 21:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 21:35 Eric Leblond [this message]
2008-12-01 21:35 ` [ULOGD2 PATCH 01/18] add ukey_* function for key assignation Eric Leblond
2008-12-01 21:36 ` [ULOGD2 PATCH 02/18] Modify usage of nflog_bind_pf function Eric Leblond
2008-12-01 21:36 ` [ULOGD2 PATCH 03/18] Get rid of addressfamily variable in NFLOG input plugin Eric Leblond
2008-12-01 21:36 ` [ULOGD2 PATCH 04/18] Document group 0 usage and suppress address_family Eric Leblond
2008-12-01 21:36 ` [ULOGD2 PATCH 05/18] Add SCTP support to BASE plugin Eric Leblond
2008-12-01 21:36 ` [ULOGD2 PATCH 06/18] SCTP support for PRINTPKT Eric Leblond
2008-12-01 21:36 ` [ULOGD2 PATCH 07/18] Add SCTP support to MySQL and PGSQL output Eric Leblond
2008-12-01 21:36 ` [ULOGD2 PATCH 08/18] Treat nice function return Eric Leblond
2008-12-01 21:36 ` [ULOGD2 PATCH 09/18] Fix stop function of NFCT plugin Eric Leblond
2008-12-01 21:36 ` [ULOGD2 PATCH 10/18] Don't free pluginstance when leaving Eric Leblond
2008-12-01 21:36 ` [ULOGD2 PATCH 11/18] Fix minor memory leak in NFLOG plugin Eric Leblond
2008-12-01 21:36 ` [ULOGD2 PATCH 12/18] Call pluginstance stop function when exiting Eric Leblond
2008-12-01 21:36 ` [ULOGD2 PATCH 13/18] Add SIGINT to list of terminal signal Eric Leblond
2008-12-01 21:36 ` [ULOGD2 PATCH 14/18] Unload plugins when quitting Eric Leblond
2008-12-01 21:36 ` [ULOGD2 PATCH 15/18] Introduce config_stop() function Eric Leblond
2008-12-01 21:36 ` [ULOGD2 PATCH 16/18] Free stacks when exiting Eric Leblond
2008-12-01 21:36 ` [ULOGD2 PATCH 17/18] Fix memory leak in destructor_nfct() Eric Leblond
2008-12-01 21:36 ` [ULOGD2 PATCH 18/18] Add valgrind compilation option Eric Leblond
2008-12-10 11:07 ` [ULOGD2 PATCH 0/18] Code cleaning, SCTP support, NFLOG logic fix Eric Leblond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228167376-22101-1-git-send-email-eric@inl.fr \
--to=eric@inl.fr \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).