* ulogd2 doesn't decode IPv6 L4 protos
@ 2008-12-08 18:27 Thomas Jacob
2008-12-08 18:27 ` [PATCH] Return true/false instead of ULOGD_IRET_OK/STOP Thomas Jacob
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Jacob @ 2008-12-08 18:27 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel
ip6_ext_hdr returns ULOGD_IRET_* codes instead of a boolean value
which prevents IPv6 layer 4 protocols from being decoded in the
raw2packet filter.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Return true/false instead of ULOGD_IRET_OK/STOP
2008-12-08 18:27 ulogd2 doesn't decode IPv6 L4 protos Thomas Jacob
@ 2008-12-08 18:27 ` Thomas Jacob
2008-12-10 10:57 ` Eric Leblond
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Jacob @ 2008-12-08 18:27 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, Thomas Jacob
Signed-off-by: Thomas Jacob <jacob@internet24.de>
---
filter/raw2packet/ulogd_raw2packet_BASE.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/filter/raw2packet/ulogd_raw2packet_BASE.c b/filter/raw2packet/ulogd_raw2packet_BASE.c
index e61d904..30822e8 100644
--- a/filter/raw2packet/ulogd_raw2packet_BASE.c
+++ b/filter/raw2packet/ulogd_raw2packet_BASE.c
@@ -751,9 +751,9 @@ static int ip6_ext_hdr(u_int8_t nexthdr)
case IPPROTO_ESP:
case IPPROTO_AH:
case IPPROTO_DSTOPTS:
- return ULOGD_IRET_OK;
+ return 1;
default:
- return ULOGD_IRET_STOP;
+ return 0;
}
}
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Return true/false instead of ULOGD_IRET_OK/STOP
2008-12-08 18:27 ` [PATCH] Return true/false instead of ULOGD_IRET_OK/STOP Thomas Jacob
@ 2008-12-10 10:57 ` Eric Leblond
0 siblings, 0 replies; 3+ messages in thread
From: Eric Leblond @ 2008-12-10 10:57 UTC (permalink / raw)
To: Thomas Jacob; +Cc: pablo, netfilter-devel
[-- Attachment #1: Type: text/plain, Size: 452 bytes --]
Hi,
Le lundi 08 décembre 2008 à 19:27 +0100, Thomas Jacob a écrit :
> Signed-off-by: Thomas Jacob <jacob@internet24.de>
> ---
> filter/raw2packet/ulogd_raw2packet_BASE.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
> - return ULOGD_IRET_OK;
> + return 1;
Good catch, applied thanks !
BR,
--
Éric Leblond, eleblond@inl.fr
Téléphone : +33 1 55 43 75 22, Fax : +33 9 57 21 48 75
INL, http://www.inl.fr
[-- Attachment #2: Ceci est une partie de message numériquement signée --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-12-10 10:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-08 18:27 ulogd2 doesn't decode IPv6 L4 protos Thomas Jacob
2008-12-08 18:27 ` [PATCH] Return true/false instead of ULOGD_IRET_OK/STOP Thomas Jacob
2008-12-10 10:57 ` Eric Leblond
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).