From: Eric Leblond <eric@inl.fr>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
netdev <netdev@vger.kernel.org>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
netfilter-devel@vger.kernel.org, kaber@trash.net
Subject: Re: linux-next: Tree for December 1 (netfilter build error)
Date: Wed, 10 Dec 2008 19:43:50 +0100 [thread overview]
Message-ID: <1228934630.5961.8.camel@ice-age> (raw)
In-Reply-To: <20081210165455.GC6391@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
Hi,
Le mercredi 10 décembre 2008 à 22:24 +0530, Kamalesh Babulal a écrit :
> * Randy Dunlap <randy.dunlap@oracle.com> [2008-12-01 11:59:34]:
>
> the function nfulnl_log_packet is exported only if
> CONFIG_NETFILTER_NETLINK_LOG is enabled, so marking the loging function
> between ifdef.
>
My patch introduces a real depedency of xt_NFLOG with nfnetlink_log
(CONFIG_NETFILTER_NETLINK_LOG) but I forget to state it in Kconfig.
I thus disagree with your patch. It is better to fix the compilation
depedency instead by modifying Kconfig.
A patch fixing this issue is to come.
BR,
--
Eric Leblond <eric@inl.fr>
INL
[-- Attachment #2: Ceci est une partie de message numériquement signée --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-12-10 18:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081201190827.2d02b1a5.sfr@canb.auug.org.au>
2008-12-01 19:59 ` linux-next: Tree for December 1 (netfilter build error) Randy Dunlap
2008-12-10 16:54 ` Kamalesh Babulal
2008-12-10 18:43 ` Eric Leblond [this message]
2008-12-10 18:49 ` netfilter: xt_NFLOG is dependant of nfnetlink_log Eric Leblond
2008-12-11 1:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228934630.5961.8.camel@ice-age \
--to=eric@inl.fr \
--cc=kaber@trash.net \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).