From: Eric Leblond <eric@inl.fr>
To: netfilter-devel@vger.kernel.org
Cc: pablo@netfilter.org
Subject: Re: [libnetfilter_log patch] Fix minor memory leak.
Date: Mon, 15 Dec 2008 17:15:46 +0100 [thread overview]
Message-ID: <1229357746.3810.16.camel@khasse.inl.fr> (raw)
In-Reply-To: <1228055643-21565-1-git-send-email-eric@inl.fr>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
Hi,
This patch has been applied to libnetfilter_log git tree.
Le dimanche 30 novembre 2008 à 15:34 +0100, Eric Leblond a écrit :
> The nflog_handle is allocated in nflog_open(). This patch adds the missing
> free in nflog_close().
>
> Signed-off-by: Eric Leblond <eric@inl.fr>
> ---
> src/libnetfilter_log.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/src/libnetfilter_log.c b/src/libnetfilter_log.c
> index 6c0936e..216cdb8 100644
> --- a/src/libnetfilter_log.c
> +++ b/src/libnetfilter_log.c
> @@ -237,7 +237,9 @@ int nflog_handle_packet(struct nflog_handle *h, char *buf, int len)
>
> int nflog_close(struct nflog_handle *h)
> {
> - return nfnl_close(h->nfnlh);
> + int ret = nfnl_close(h->nfnlh);
> + free(h);
> + return ret;
> }
>
> /* bind nf_queue from a specific protocol family */
BR,
--
Éric Leblond <eric@inl.fr>
INL, http://www.inl.fr/
NuFW, http://www.nufw.org
[-- Attachment #2: Ceci est une partie de message numériquement signée --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2008-12-15 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-30 14:34 [libnetfilter_log patch] Fix minor memory leak Eric Leblond
2008-12-15 16:15 ` Eric Leblond [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229357746.3810.16.camel@khasse.inl.fr \
--to=eric@inl.fr \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).