netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Leblond <eric@inl.fr>
To: netfilter-devel@vger.kernel.org
Cc: Eric Leblond <eric@inl.fr>
Subject: [libnetfilter_queue 3/4] Suppress double call of nfnl_subsys_close()
Date: Fri, 19 Dec 2008 22:36:30 +0100	[thread overview]
Message-ID: <1229722591-7836-4-git-send-email-eric@inl.fr> (raw)
In-Reply-To: <1229722591-7836-1-git-send-email-eric@inl.fr>

nfnl_close() is calling nfnl_subsys_close() for all available
subsys. Thus it is not necessary to call it in the nfq_close()
function.

Signed-off-by: Eric Leblond <eric@inl.fr>
---
 src/libnetfilter_queue.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/libnetfilter_queue.c b/src/libnetfilter_queue.c
index e7fbfcc..f5611dd 100644
--- a/src/libnetfilter_queue.c
+++ b/src/libnetfilter_queue.c
@@ -252,7 +252,6 @@ int nfq_close(struct nfq_handle *h)
 {
 	int ret;
 	
-	nfnl_subsys_close(h->nfnlssh);
 	ret = nfnl_close(h->nfnlh);
 	if (ret == 0)
 		free(h);
-- 
1.5.6.3


  parent reply	other threads:[~2008-12-19 21:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-19 21:36 [libnetfilter_queue 0/4] misc code cleaning and documentation Eric Leblond
2008-12-19 21:36 ` [libnetfilter_queue 1/4] Change variable name to have an homogeneous naming Eric Leblond
2008-12-19 21:36 ` [libnetfilter_queue 2/4] Use nfq_fd function instead of call to nfnetlink function Eric Leblond
2008-12-19 21:36 ` Eric Leblond [this message]
2008-12-19 21:36 ` [libnetfilter_queue 4/4] Switch documentation style to doxygen Eric Leblond
2008-12-22 10:45   ` Pablo Neira Ayuso
2008-12-22 10:55     ` Eric Leblond
2008-12-22 10:59       ` [libnetfilter_queue] Add doxygen config file Eric Leblond
2008-12-22 11:41         ` Pablo Neira Ayuso
2008-12-22 12:56           ` Eric Leblond
2008-12-22 12:32       ` [libnetfilter_queue 4/4] Switch documentation style to doxygen Pablo Neira Ayuso
2008-12-22 13:50     ` Jan Engelhardt
2008-12-22 22:02       ` Pablo Neira Ayuso
2008-12-22 22:08         ` Jan Engelhardt
2008-12-22 10:48 ` [libnetfilter_queue 0/4] misc code cleaning and documentation Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229722591-7836-4-git-send-email-eric@inl.fr \
    --to=eric@inl.fr \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).