From: Eric Leblond <eric@inl.fr>
To: netfilter-devel@vger.kernel.org
Cc: Eric Leblond <eric@inl.fr>
Subject: [libnetfilter_log 2/3] Set nflog_errno as needed.
Date: Mon, 29 Dec 2008 22:33:23 +0100 [thread overview]
Message-ID: <1230586404-24639-3-git-send-email-eric@inl.fr> (raw)
In-Reply-To: <1230586404-24639-1-git-send-email-eric@inl.fr>
Some FIXME were put to fix some issues related to nflog_errno not being set. In both case, this was
related to error treatment of libnfnetlink function. As these functions are setting errno to the
correct value, this patch simply copy errno to nflog_errno in libnetfilter_log.
Signed-off-by: Eric Leblond <eric@inl.fr>
---
src/libnetfilter_log.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/libnetfilter_log.c b/src/libnetfilter_log.c
index ed92561..9343f90 100644
--- a/src/libnetfilter_log.c
+++ b/src/libnetfilter_log.c
@@ -178,7 +178,7 @@ struct nflog_handle *nflog_open_nfnl(struct nfnl_handle *nfnlh)
h->nfnlssh = nfnl_subsys_open(h->nfnlh, NFNL_SUBSYS_ULOG,
NFULNL_MSG_MAX, 0);
if (!h->nfnlssh) {
- /* FIXME: nflog_errno */
+ nflog_errno = errno;
goto out_free;
}
@@ -210,7 +210,7 @@ struct nflog_handle *nflog_open(void)
nfnlh = nfnl_open();
if (!nfnlh) {
- /* FIXME: nflog_errno */
+ nflog_errno = errno;
return NULL;
}
--
1.5.6.3
next prev parent reply other threads:[~2008-12-29 21:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 21:33 [libnetfilter_log 0/3] Misc code cleaning Eric Leblond
2008-12-29 21:33 ` [libnetfilter_log 1/3] Suppress reference to libnetfilter_queue which is the model of libnetfilter_log Eric Leblond
2008-12-30 11:19 ` Pablo Neira Ayuso
2008-12-29 21:33 ` Eric Leblond [this message]
2008-12-30 11:19 ` [libnetfilter_log 2/3] Set nflog_errno as needed Pablo Neira Ayuso
2008-12-29 21:33 ` [libnetfilter_log 3/3] Suppress NFULNL_MSG_CONFIG callback registration Eric Leblond
2008-12-30 11:20 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230586404-24639-3-git-send-email-eric@inl.fr \
--to=eric@inl.fr \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).