* [PATCH] netfilter: fix tuple inversion for Node information request.
@ 2009-01-19 22:20 Eric Leblond
2009-01-26 13:43 ` Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Eric Leblond @ 2009-01-19 22:20 UTC (permalink / raw)
To: kaber, yasuyuki.kozakai; +Cc: netfilter-devel, Eric Leblond
The patch fixes a typo in the inverse mapping of Node Information
request. Following draft-ietf-ipngwg-icmp-name-lookups-09, "Querier"
sends a type 139 (ICMPV6_NI_QUERY) packet to "Responder" which answer
with a type 140 (ICMPV6_NI_REPLY) packet.
Signed-off-by: Eric Leblond <eric@inl.fr>
---
net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c b/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c
index bd52151..7a98857 100644
--- a/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c
+++ b/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c
@@ -49,8 +49,8 @@ static bool icmpv6_pkt_to_tuple(const struct sk_buff *skb,
static const u_int8_t invmap[] = {
[ICMPV6_ECHO_REQUEST - 128] = ICMPV6_ECHO_REPLY + 1,
[ICMPV6_ECHO_REPLY - 128] = ICMPV6_ECHO_REQUEST + 1,
- [ICMPV6_NI_QUERY - 128] = ICMPV6_NI_QUERY + 1,
- [ICMPV6_NI_REPLY - 128] = ICMPV6_NI_REPLY +1
+ [ICMPV6_NI_QUERY - 128] = ICMPV6_NI_REPLY + 1,
+ [ICMPV6_NI_REPLY - 128] = ICMPV6_NI_QUERY +1
};
static bool icmpv6_invert_tuple(struct nf_conntrack_tuple *tuple,
--
1.5.6.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] netfilter: fix tuple inversion for Node information request.
2009-01-19 22:20 [PATCH] netfilter: fix tuple inversion for Node information request Eric Leblond
@ 2009-01-26 13:43 ` Patrick McHardy
0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2009-01-26 13:43 UTC (permalink / raw)
To: Eric Leblond; +Cc: yasuyuki.kozakai, netfilter-devel
Eric Leblond wrote:
> The patch fixes a typo in the inverse mapping of Node Information
> request. Following draft-ietf-ipngwg-icmp-name-lookups-09, "Querier"
> sends a type 139 (ICMPV6_NI_QUERY) packet to "Responder" which answer
> with a type 140 (ICMPV6_NI_REPLY) packet.
Looks good, applied. Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-26 13:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-19 22:20 [PATCH] netfilter: fix tuple inversion for Node information request Eric Leblond
2009-01-26 13:43 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).