Re: [PATCH] netfilter: sysctl support of logger choice.

[Eric Leblond <eric@inl.fr>]

[-- Attachment #1: Type: text/plain, Size: 870 bytes --]

Hi,

Le jeudi 19 mars 2009 à 10:45 +0100, Patrick McHardy a écrit :
> Eric Leblond wrote:
> > This patchs adds support of modification of the used logger via sysctl.
...
> > By echoing "NONE" to a /proc/sys/net/netfilter/nf_log/PROTO file, the
> > logger corresponding to this PROTO is set to NULL.
> > 
...
> > +	if (write) {
> > +		if (!strnicmp(buffer, "NONE", *lenp - 1)) {
> 
> What is the motivation here for not doing a full comparison?
> Suggested change: use strcmp

Hmmm that's correct. There is no motivation at all for insensitive
check. I should have done this.

The rest of the modifications are ok for me.

...
> > +		return r;
> 
> I previously didn't realize an error will cause a panic. I'll add a
> comment explaning why unrolling is unnecessary.

OK, interesting point.

BR,
-- 
Eric Leblond <eric@inl.fr>
INL SARL

[-- Attachment #2: Ceci est une partie de message numériquement signée --]
[-- Type: application/pgp-signature, Size: 189 bytes --]