Re: ulogd2 commit

[Eric Leblond <eric@inl.fr>]

[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]

Hi,

Le vendredi 17 avril 2009 à 12:52 +0200, Pablo Neira Ayuso a écrit :
> Hi Eric, Pierre,
> 
> Please, could you justify the need for commit
> 0ff525cb0506b2c043bc9df6d7e7b486c865bc38?
> 
> http://git.netfilter.org/cgi-bin/gitweb.cgi?p=ulogd2.git;a=commit;h=0ff525cb0506b2c043bc9df6d7e7b486c865bc38
> 
> I don't think that it's a good idea to support external compilation of
> ulogd2 modules. We should promote people to push forward things to mainline.

I clearly agree with the goal of promoting people to push forward things
to mainline but it has to be done by openness and reactivity of
mainteners, not by technical means.

But let looks at the diffstat of this commit:
 include/Makefile.am       |    1 +
 include/ulogd/Makefile.am |    3 +--
 include/ulogd/ulogd.h     |    2 ++
 3 files changed, 4 insertions(+), 2 deletions(-)

That's really not a big work for anyone to arrive to the same result. An
other point is that compiling outside of tree require you to maintain
your own build system which is quiet boring.

Thus, using git to maintain you own forked branch is the easiest way to
keep your work hidden and/or non public.

IMHO, this patch does not change anything about external contribution.

BR,
-- 
Eric Leblond <eric@inl.fr>
INL: http://www.inl.fr/
NuFW: http://www.nufw.org/

[-- Attachment #2: Ceci est une partie de message numériquement signée --]
[-- Type: application/pgp-signature, Size: 189 bytes --]