From: Jan Engelhardt <jengelh@medozas.de>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH 8/9] extensions: add const qualifiers in print/save functions
Date: Sun, 3 May 2009 21:54:32 +0200 [thread overview]
Message-ID: <1241380473-22262-9-git-send-email-jengelh@medozas.de> (raw)
In-Reply-To: <1241380473-22262-1-git-send-email-jengelh@medozas.de>
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
extensions/libip6t_hl.c | 2 +-
extensions/libipt_DNAT.c | 4 ++--
extensions/libipt_MASQUERADE.c | 10 ++++------
extensions/libipt_NETMAP.c | 5 ++---
extensions/libipt_REDIRECT.c | 10 ++++------
extensions/libipt_SAME.c | 10 ++++------
extensions/libipt_SET.c | 6 ++----
extensions/libipt_SNAT.c | 4 ++--
extensions/libipt_realm.c | 4 ++--
extensions/libipt_set.c | 6 ++----
extensions/libxt_CONNSECMARK.c | 6 +++---
extensions/libxt_RATEEST.c | 2 +-
extensions/libxt_SECMARK.c | 4 ++--
| 4 ++--
extensions/libxt_connbytes.c | 8 ++++----
extensions/libxt_connmark.c | 4 ++--
extensions/libxt_conntrack.c | 5 +++--
extensions/libxt_hashlimit.c | 6 ++----
extensions/libxt_helper.c | 4 ++--
extensions/libxt_limit.c | 4 ++--
extensions/libxt_mark.c | 4 ++--
extensions/libxt_physdev.c | 6 ++----
extensions/libxt_pkttype.c | 6 +++---
extensions/libxt_quota.c | 4 ++--
extensions/libxt_rateest.c | 7 ++++---
extensions/libxt_state.c | 4 ++--
extensions/libxt_statistic.c | 4 ++--
extensions/libxt_time.c | 2 +-
28 files changed, 66 insertions(+), 79 deletions(-)
diff --git a/extensions/libip6t_hl.c b/extensions/libip6t_hl.c
index cc84018..c61d941 100644
--- a/extensions/libip6t_hl.c
+++ b/extensions/libip6t_hl.c
@@ -90,7 +90,7 @@ static void hl_check(unsigned int flags)
static void hl_print(const void *ip, const struct xt_entry_match *match,
bool numeric)
{
- static const char *op[] = {
+ static const char *const op[] = {
[IP6T_HL_EQ] = "==",
[IP6T_HL_NE] = "!=",
[IP6T_HL_LT] = "<",
diff --git a/extensions/libipt_DNAT.c b/extensions/libipt_DNAT.c
index 4f35aa2..2dceee2 100644
--- a/extensions/libipt_DNAT.c
+++ b/extensions/libipt_DNAT.c
@@ -220,7 +220,7 @@ static void print_range(const struct nf_nat_range *r)
static void DNAT_print(const void *ip, const struct xt_entry_target *target,
bool numeric)
{
- struct ipt_natinfo *info = (void *)target;
+ const struct ipt_natinfo *info = (const void *)target;
unsigned int i = 0;
printf("to:");
@@ -236,7 +236,7 @@ static void DNAT_print(const void *ip, const struct xt_entry_target *target,
static void DNAT_save(const void *ip, const struct xt_entry_target *target)
{
- struct ipt_natinfo *info = (void *)target;
+ const struct ipt_natinfo *info = (const void *)target;
unsigned int i = 0;
for (i = 0; i < info->mr.rangesize; i++) {
diff --git a/extensions/libipt_MASQUERADE.c b/extensions/libipt_MASQUERADE.c
index 6d2446e..ad25468 100644
--- a/extensions/libipt_MASQUERADE.c
+++ b/extensions/libipt_MASQUERADE.c
@@ -113,9 +113,8 @@ static void
MASQUERADE_print(const void *ip, const struct xt_entry_target *target,
bool numeric)
{
- struct nf_nat_multi_range *mr
- = (struct nf_nat_multi_range *)target->data;
- struct nf_nat_range *r = &mr->range[0];
+ const struct nf_nat_multi_range *mr = (const void *)target->data;
+ const struct nf_nat_range *r = &mr->range[0];
if (r->flags & IP_NAT_RANGE_PROTO_SPECIFIED) {
printf("masq ports: ");
@@ -132,9 +131,8 @@ MASQUERADE_print(const void *ip, const struct xt_entry_target *target,
static void
MASQUERADE_save(const void *ip, const struct xt_entry_target *target)
{
- struct nf_nat_multi_range *mr
- = (struct nf_nat_multi_range *)target->data;
- struct nf_nat_range *r = &mr->range[0];
+ const struct nf_nat_multi_range *mr = (const void *)target->data;
+ const struct nf_nat_range *r = &mr->range[0];
if (r->flags & IP_NAT_RANGE_PROTO_SPECIFIED) {
printf("--to-ports %hu", ntohs(r->min.tcp.port));
diff --git a/extensions/libipt_NETMAP.c b/extensions/libipt_NETMAP.c
index 4d4b125..2be72c1 100644
--- a/extensions/libipt_NETMAP.c
+++ b/extensions/libipt_NETMAP.c
@@ -141,9 +141,8 @@ static void NETMAP_check(unsigned int flags)
static void NETMAP_print(const void *ip, const struct xt_entry_target *target,
bool numeric)
{
- struct nf_nat_multi_range *mr
- = (struct nf_nat_multi_range *)target->data;
- struct nf_nat_range *r = &mr->range[0];
+ const struct nf_nat_multi_range *mr = (const void *)target->data;
+ const struct nf_nat_range *r = &mr->range[0];
struct in_addr a;
int bits;
diff --git a/extensions/libipt_REDIRECT.c b/extensions/libipt_REDIRECT.c
index 83b0f22..2bc0ad1 100644
--- a/extensions/libipt_REDIRECT.c
+++ b/extensions/libipt_REDIRECT.c
@@ -126,9 +126,8 @@ REDIRECT_parse(int c, char **argv, bool invert, unsigned int *flags,
static void REDIRECT_print(const void *ip, const struct xt_entry_target *target,
bool numeric)
{
- struct nf_nat_multi_range *mr
- = (struct nf_nat_multi_range *)target->data;
- struct nf_nat_range *r = &mr->range[0];
+ const struct nf_nat_multi_range *mr = (const void *)target->data;
+ const struct nf_nat_range *r = &mr->range[0];
if (r->flags & IP_NAT_RANGE_PROTO_SPECIFIED) {
printf("redir ports ");
@@ -143,9 +142,8 @@ static void REDIRECT_print(const void *ip, const struct xt_entry_target *target,
static void REDIRECT_save(const void *ip, const struct xt_entry_target *target)
{
- struct nf_nat_multi_range *mr
- = (struct nf_nat_multi_range *)target->data;
- struct nf_nat_range *r = &mr->range[0];
+ const struct nf_nat_multi_range *mr = (const void *)target->data;
+ const struct nf_nat_range *r = &mr->range[0];
if (r->flags & IP_NAT_RANGE_PROTO_SPECIFIED) {
printf("--to-ports ");
diff --git a/extensions/libipt_SAME.c b/extensions/libipt_SAME.c
index bbd63c7..8fbda49 100644
--- a/extensions/libipt_SAME.c
+++ b/extensions/libipt_SAME.c
@@ -139,14 +139,13 @@ static void SAME_print(const void *ip, const struct xt_entry_target *target,
bool numeric)
{
unsigned int count;
- struct ipt_same_info *mr
- = (struct ipt_same_info *)target->data;
+ const struct ipt_same_info *mr = (const void *)target->data;
int random_selection = 0;
printf("same:");
for (count = 0; count < mr->rangesize; count++) {
- struct nf_nat_range *r = &mr->range[count];
+ const struct nf_nat_range *r = &mr->range[count];
struct in_addr a;
a.s_addr = r->min_ip;
@@ -172,12 +171,11 @@ static void SAME_print(const void *ip, const struct xt_entry_target *target,
static void SAME_save(const void *ip, const struct xt_entry_target *target)
{
unsigned int count;
- struct ipt_same_info *mr
- = (struct ipt_same_info *)target->data;
+ const struct ipt_same_info *mr = (const void *)target->data;
int random_selection = 0;
for (count = 0; count < mr->rangesize; count++) {
- struct nf_nat_range *r = &mr->range[count];
+ const struct nf_nat_range *r = &mr->range[count];
struct in_addr a;
a.s_addr = r->min_ip;
diff --git a/extensions/libipt_SET.c b/extensions/libipt_SET.c
index 6f409a1..db0d433 100644
--- a/extensions/libipt_SET.c
+++ b/extensions/libipt_SET.c
@@ -130,8 +130,7 @@ print_target(const char *prefix, const struct ipt_set_info *info)
static void SET_print(const void *ip, const struct xt_entry_target *target,
bool numeric)
{
- struct ipt_set_info_target *info =
- (struct ipt_set_info_target *) target->data;
+ const struct ipt_set_info_target *info = (const void *)target->data;
print_target("add-set", &info->add_set);
print_target("del-set", &info->del_set);
@@ -139,8 +138,7 @@ static void SET_print(const void *ip, const struct xt_entry_target *target,
static void SET_save(const void *ip, const struct xt_entry_target *target)
{
- struct ipt_set_info_target *info =
- (struct ipt_set_info_target *) target->data;
+ const struct ipt_set_info_target *info = (const void *)target->data;
print_target("--add-set", &info->add_set);
print_target("--del-set", &info->del_set);
diff --git a/extensions/libipt_SNAT.c b/extensions/libipt_SNAT.c
index 11ef08f..c7eccd0 100644
--- a/extensions/libipt_SNAT.c
+++ b/extensions/libipt_SNAT.c
@@ -220,7 +220,7 @@ static void print_range(const struct nf_nat_range *r)
static void SNAT_print(const void *ip, const struct xt_entry_target *target,
bool numeric)
{
- struct ipt_natinfo *info = (void *)target;
+ const struct ipt_natinfo *info = (const void *)target;
unsigned int i = 0;
printf("to:");
@@ -236,7 +236,7 @@ static void SNAT_print(const void *ip, const struct xt_entry_target *target,
static void SNAT_save(const void *ip, const struct xt_entry_target *target)
{
- struct ipt_natinfo *info = (void *)target;
+ const struct ipt_natinfo *info = (const void *)target;
unsigned int i = 0;
for (i = 0; i < info->mr.rangesize; i++) {
diff --git a/extensions/libipt_realm.c b/extensions/libipt_realm.c
index bde3472..88fa499 100644
--- a/extensions/libipt_realm.c
+++ b/extensions/libipt_realm.c
@@ -208,7 +208,7 @@ print_realm(unsigned long id, unsigned long mask, bool numeric)
static void realm_print(const void *ip, const struct xt_entry_match *match,
bool numeric)
{
- struct ipt_realm_info *ri = (struct ipt_realm_info *) match->data;
+ const struct ipt_realm_info *ri = (const void *)match->data;
if (ri->invert)
printf("! ");
@@ -219,7 +219,7 @@ static void realm_print(const void *ip, const struct xt_entry_match *match,
static void realm_save(const void *ip, const struct xt_entry_match *match)
{
- struct ipt_realm_info *ri = (struct ipt_realm_info *) match->data;
+ const struct ipt_realm_info *ri = (const void *)match->data;
if (ri->invert)
printf("! ");
diff --git a/extensions/libipt_set.c b/extensions/libipt_set.c
index b704852..cfa64dc 100644
--- a/extensions/libipt_set.c
+++ b/extensions/libipt_set.c
@@ -122,16 +122,14 @@ print_match(const char *prefix, const struct ipt_set_info *info)
static void set_print(const void *ip, const struct xt_entry_match *match,
bool numeric)
{
- struct ipt_set_info_match *info =
- (struct ipt_set_info_match *) match->data;
+ const struct ipt_set_info_match *info = (const void *)match->data;
print_match("set", &info->match_set);
}
static void set_save(const void *ip, const struct xt_entry_match *match)
{
- struct ipt_set_info_match *info =
- (struct ipt_set_info_match *) match->data;
+ const struct ipt_set_info_match *info = (const void *)match->data;
print_match("--set", &info->match_set);
}
diff --git a/extensions/libxt_CONNSECMARK.c b/extensions/libxt_CONNSECMARK.c
index d48d1f6..f32d860 100644
--- a/extensions/libxt_CONNSECMARK.c
+++ b/extensions/libxt_CONNSECMARK.c
@@ -70,7 +70,7 @@ static void CONNSECMARK_check(unsigned int flags)
"or --restore is allowed");
}
-static void print_connsecmark(struct xt_connsecmark_target_info *info)
+static void print_connsecmark(const struct xt_connsecmark_target_info *info)
{
switch (info->mode) {
case CONNSECMARK_SAVE:
@@ -90,7 +90,7 @@ static void
CONNSECMARK_print(const void *ip, const struct xt_entry_target *target,
bool numeric)
{
- struct xt_connsecmark_target_info *info =
+ const struct xt_connsecmark_target_info *info =
(struct xt_connsecmark_target_info*)(target)->data;
printf("CONNSECMARK ");
@@ -100,7 +100,7 @@ CONNSECMARK_print(const void *ip, const struct xt_entry_target *target,
static void
CONNSECMARK_save(const void *ip, const struct xt_entry_target *target)
{
- struct xt_connsecmark_target_info *info =
+ const struct xt_connsecmark_target_info *info =
(struct xt_connsecmark_target_info*)target->data;
printf("--");
diff --git a/extensions/libxt_RATEEST.c b/extensions/libxt_RATEEST.c
index bd70852..e1fbdda 100644
--- a/extensions/libxt_RATEEST.c
+++ b/extensions/libxt_RATEEST.c
@@ -175,7 +175,7 @@ RATEEST_final_check(unsigned int flags)
static void
__RATEEST_print(const struct xt_entry_target *target, const char *prefix)
{
- struct xt_rateest_target_info *info = (void *)target->data;
+ const struct xt_rateest_target_info *info = (const void *)target->data;
unsigned int local_interval;
unsigned int local_ewma_log;
diff --git a/extensions/libxt_SECMARK.c b/extensions/libxt_SECMARK.c
index 36f9d7c..c6a9116 100644
--- a/extensions/libxt_SECMARK.c
+++ b/extensions/libxt_SECMARK.c
@@ -77,7 +77,7 @@ static void print_secmark(struct xt_secmark_target_info *info)
static void SECMARK_print(const void *ip, const struct xt_entry_target *target,
bool numeric)
{
- struct xt_secmark_target_info *info =
+ const struct xt_secmark_target_info *info =
(struct xt_secmark_target_info*)(target)->data;
printf("SECMARK ");
@@ -86,7 +86,7 @@ static void SECMARK_print(const void *ip, const struct xt_entry_target *target,
static void SECMARK_save(const void *ip, const struct xt_entry_target *target)
{
- struct xt_secmark_target_info *info =
+ const struct xt_secmark_target_info *info =
(struct xt_secmark_target_info*)target->data;
printf("--");
--git a/extensions/libxt_comment.c b/extensions/libxt_comment.c
index 79d1594..da959c7 100644
--- a/extensions/libxt_comment.c
+++ b/extensions/libxt_comment.c
@@ -72,7 +72,7 @@ static void comment_check(unsigned int flags)
static void
comment_print(const void *ip, const struct xt_entry_match *match, bool numeric)
{
- struct xt_comment_info *commentinfo = (struct xt_comment_info *)match->data;
+ struct xt_comment_info *commentinfo = (void *)match->data;
commentinfo->comment[XT_MAX_COMMENT_LEN-1] = '\0';
printf("/* %s */ ", commentinfo->comment);
@@ -82,7 +82,7 @@ comment_print(const void *ip, const struct xt_entry_match *match, bool numeric)
static void
comment_save(const void *ip, const struct xt_entry_match *match)
{
- struct xt_comment_info *commentinfo = (struct xt_comment_info *)match->data;
+ struct xt_comment_info *commentinfo = (void *)match->data;
commentinfo->comment[XT_MAX_COMMENT_LEN-1] = '\0';
printf("--comment ");
diff --git a/extensions/libxt_connbytes.c b/extensions/libxt_connbytes.c
index d465fc4..bf1d05f 100644
--- a/extensions/libxt_connbytes.c
+++ b/extensions/libxt_connbytes.c
@@ -103,7 +103,7 @@ static void connbytes_check(unsigned int flags)
"`--connbytes-dir' and `--connbytes-mode'");
}
-static void print_mode(struct xt_connbytes_info *sinfo)
+static void print_mode(const struct xt_connbytes_info *sinfo)
{
switch (sinfo->what) {
case XT_CONNBYTES_PKTS:
@@ -121,7 +121,7 @@ static void print_mode(struct xt_connbytes_info *sinfo)
}
}
-static void print_direction(struct xt_connbytes_info *sinfo)
+static void print_direction(const struct xt_connbytes_info *sinfo)
{
switch (sinfo->direction) {
case XT_CONNBYTES_DIR_ORIGINAL:
@@ -143,7 +143,7 @@ static void
connbytes_print(const void *ip, const struct xt_entry_match *match,
bool numeric)
{
- struct xt_connbytes_info *sinfo = (struct xt_connbytes_info *)match->data;
+ const struct xt_connbytes_info *sinfo = (const void *)match->data;
if (sinfo->count.from > sinfo->count.to)
printf("connbytes ! %llu:%llu ",
@@ -163,7 +163,7 @@ connbytes_print(const void *ip, const struct xt_entry_match *match,
static void connbytes_save(const void *ip, const struct xt_entry_match *match)
{
- struct xt_connbytes_info *sinfo = (struct xt_connbytes_info *)match->data;
+ const struct xt_connbytes_info *sinfo = (const void *)match->data;
if (sinfo->count.from > sinfo->count.to)
printf("! --connbytes %llu:%llu ",
diff --git a/extensions/libxt_connmark.c b/extensions/libxt_connmark.c
index fa16e96..4418e6a 100644
--- a/extensions/libxt_connmark.c
+++ b/extensions/libxt_connmark.c
@@ -123,7 +123,7 @@ static void
connmark_print(const void *ip, const struct xt_entry_match *match,
bool numeric)
{
- struct xt_connmark_info *info = (struct xt_connmark_info *)match->data;
+ const struct xt_connmark_info *info = (const void *)match->data;
printf("CONNMARK match ");
if (info->invert)
@@ -145,7 +145,7 @@ connmark_mt_print(const void *ip, const struct xt_entry_match *match,
static void connmark_save(const void *ip, const struct xt_entry_match *match)
{
- struct xt_connmark_info *info = (struct xt_connmark_info *)match->data;
+ const struct xt_connmark_info *info = (const void *)match->data;
if (info->invert)
printf("! ");
diff --git a/extensions/libxt_conntrack.c b/extensions/libxt_conntrack.c
index 4b6c3c5..0ede034 100644
--- a/extensions/libxt_conntrack.c
+++ b/extensions/libxt_conntrack.c
@@ -780,7 +780,8 @@ conntrack_dump_addr(const union nf_inet_addr *addr,
}
static void
-print_addr(struct in_addr *addr, struct in_addr *mask, bool inv, bool numeric)
+print_addr(const struct in_addr *addr, const struct in_addr *mask,
+ bool inv, bool numeric)
{
char buf[BUFSIZ];
@@ -803,7 +804,7 @@ static void
matchinfo_print(const void *ip, const struct xt_entry_match *match,
bool numeric, const char *optpfx)
{
- struct xt_conntrack_info *sinfo = (void *)match->data;
+ const struct xt_conntrack_info *sinfo = (const void *)match->data;
if(sinfo->flags & XT_CONNTRACK_STATE) {
if (sinfo->invflags & XT_CONNTRACK_STATE)
diff --git a/extensions/libxt_hashlimit.c b/extensions/libxt_hashlimit.c
index 4fd844f..1ca78d8 100644
--- a/extensions/libxt_hashlimit.c
+++ b/extensions/libxt_hashlimit.c
@@ -525,8 +525,7 @@ static void print_mode(unsigned int mode, char separator)
static void hashlimit_print(const void *ip,
const struct xt_entry_match *match, bool numeric)
{
- struct xt_hashlimit_info *r =
- (struct xt_hashlimit_info *)match->data;
+ const struct xt_hashlimit_info *r = (const void *)match->data;
fputs("limit: avg ", stdout); print_rate(r->cfg.avg);
printf("burst %u ", r->cfg.burst);
fputs("mode ", stdout);
@@ -590,8 +589,7 @@ hashlimit_mt6_print(const void *ip, const struct xt_entry_match *match,
static void hashlimit_save(const void *ip, const struct xt_entry_match *match)
{
- struct xt_hashlimit_info *r =
- (struct xt_hashlimit_info *)match->data;
+ const struct xt_hashlimit_info *r = (const void *)match->data;
fputs("--hashlimit ", stdout); print_rate(r->cfg.avg);
if (r->cfg.burst != XT_HASHLIMIT_BURST)
diff --git a/extensions/libxt_helper.c b/extensions/libxt_helper.c
index d5e5670..951db5c 100644
--- a/extensions/libxt_helper.c
+++ b/extensions/libxt_helper.c
@@ -56,14 +56,14 @@ static void helper_check(unsigned int flags)
static void
helper_print(const void *ip, const struct xt_entry_match *match, bool numeric)
{
- struct xt_helper_info *info = (struct xt_helper_info *)match->data;
+ const struct xt_helper_info *info = (const void *)match->data;
printf("helper match %s\"%s\" ", info->invert ? "! " : "", info->name);
}
static void helper_save(const void *ip, const struct xt_entry_match *match)
{
- struct xt_helper_info *info = (struct xt_helper_info *)match->data;
+ const struct xt_helper_info *info = (const void *)match->data;
printf("%s--helper ",info->invert ? "! " : "");
xtables_save_string(info->name);
diff --git a/extensions/libxt_limit.c b/extensions/libxt_limit.c
index e408e3e..a999531 100644
--- a/extensions/libxt_limit.c
+++ b/extensions/libxt_limit.c
@@ -145,14 +145,14 @@ static void print_rate(u_int32_t period)
static void
limit_print(const void *ip, const struct xt_entry_match *match, bool numeric)
{
- struct xt_rateinfo *r = (struct xt_rateinfo *)match->data;
+ const struct xt_rateinfo *r = (const void *)match->data;
printf("limit: avg "); print_rate(r->avg);
printf("burst %u ", r->burst);
}
static void limit_save(const void *ip, const struct xt_entry_match *match)
{
- struct xt_rateinfo *r = (struct xt_rateinfo *)match->data;
+ const struct xt_rateinfo *r = (const void *)match->data;
printf("--limit "); print_rate(r->avg);
if (r->burst != XT_LIMIT_BURST)
diff --git a/extensions/libxt_mark.c b/extensions/libxt_mark.c
index c6299ff..eb45c24 100644
--- a/extensions/libxt_mark.c
+++ b/extensions/libxt_mark.c
@@ -110,7 +110,7 @@ mark_mt_print(const void *ip, const struct xt_entry_match *match, bool numeric)
static void
mark_print(const void *ip, const struct xt_entry_match *match, bool numeric)
{
- struct xt_mark_info *info = (struct xt_mark_info *)match->data;
+ const struct xt_mark_info *info = (const void *)match->data;
printf("MARK match ");
@@ -134,7 +134,7 @@ static void mark_mt_save(const void *ip, const struct xt_entry_match *match)
static void
mark_save(const void *ip, const struct xt_entry_match *match)
{
- struct xt_mark_info *info = (struct xt_mark_info *)match->data;
+ const struct xt_mark_info *info = (const void *)match->data;
if (info->invert)
printf("! ");
diff --git a/extensions/libxt_physdev.c b/extensions/libxt_physdev.c
index 1ce408c..39fff0b 100644
--- a/extensions/libxt_physdev.c
+++ b/extensions/libxt_physdev.c
@@ -115,8 +115,7 @@ static void physdev_check(unsigned int flags)
static void
physdev_print(const void *ip, const struct xt_entry_match *match, bool numeric)
{
- struct xt_physdev_info *info =
- (struct xt_physdev_info*)match->data;
+ const struct xt_physdev_info *info = (const void *)match->data;
printf("PHYSDEV match");
if (info->bitmask & XT_PHYSDEV_OP_ISIN)
@@ -140,8 +139,7 @@ physdev_print(const void *ip, const struct xt_entry_match *match, bool numeric)
static void physdev_save(const void *ip, const struct xt_entry_match *match)
{
- struct xt_physdev_info *info =
- (struct xt_physdev_info*)match->data;
+ const struct xt_physdev_info *info = (const void *)match->data;
if (info->bitmask & XT_PHYSDEV_OP_ISIN)
printf("%s--physdev-is-in ",
diff --git a/extensions/libxt_pkttype.c b/extensions/libxt_pkttype.c
index 294c854..f8ad175 100644
--- a/extensions/libxt_pkttype.c
+++ b/extensions/libxt_pkttype.c
@@ -112,7 +112,7 @@ static void pkttype_check(unsigned int flags)
xtables_error(PARAMETER_PROBLEM, "You must specify \"--pkt-type\"");
}
-static void print_pkttype(struct xt_pkttype_info *info)
+static void print_pkttype(const struct xt_pkttype_info *info)
{
unsigned int i;
@@ -131,7 +131,7 @@ static void print_pkttype(struct xt_pkttype_info *info)
static void pkttype_print(const void *ip, const struct xt_entry_match *match,
bool numeric)
{
- struct xt_pkttype_info *info = (struct xt_pkttype_info *)match->data;
+ const struct xt_pkttype_info *info = (const void *)match->data;
printf("PKTTYPE %s= ", info->invert?"!":"");
print_pkttype(info);
@@ -139,7 +139,7 @@ static void pkttype_print(const void *ip, const struct xt_entry_match *match,
static void pkttype_save(const void *ip, const struct xt_entry_match *match)
{
- struct xt_pkttype_info *info = (struct xt_pkttype_info *)match->data;
+ const struct xt_pkttype_info *info = (const void *)match->data;
printf("%s--pkt-type ", info->invert ? "! " : "");
print_pkttype(info);
diff --git a/extensions/libxt_quota.c b/extensions/libxt_quota.c
index 6843841..ae283f5 100644
--- a/extensions/libxt_quota.c
+++ b/extensions/libxt_quota.c
@@ -26,14 +26,14 @@ static void quota_help(void)
static void
quota_print(const void *ip, const struct xt_entry_match *match, bool numeric)
{
- struct xt_quota_info *q = (struct xt_quota_info *) match->data;
+ const struct xt_quota_info *q = (const void *)match->data;
printf("quota: %llu bytes", (unsigned long long) q->quota);
}
static void
quota_save(const void *ip, const struct xt_entry_match *match)
{
- struct xt_quota_info *q = (struct xt_quota_info *) match->data;
+ const struct xt_quota_info *q = (const void *)match->data;
printf("--quota %llu ", (unsigned long long) q->quota);
}
diff --git a/extensions/libxt_rateest.c b/extensions/libxt_rateest.c
index 2c17326..dbc6f17 100644
--- a/extensions/libxt_rateest.c
+++ b/extensions/libxt_rateest.c
@@ -333,7 +333,8 @@ rateest_print_rate(u_int32_t rate, bool numeric)
}
static void
-rateest_print_mode(struct xt_rateest_match_info *info, const char *prefix)
+rateest_print_mode(const struct xt_rateest_match_info *info,
+ const char *prefix)
{
if (info->flags & XT_RATEEST_MATCH_INVERT)
printf("! ");
@@ -356,7 +357,7 @@ rateest_print_mode(struct xt_rateest_match_info *info, const char *prefix)
static void
rateest_print(const void *ip, const struct xt_entry_match *match, bool numeric)
{
- struct xt_rateest_match_info *info = (void *)match->data;
+ const struct xt_rateest_match_info *info = (const void *)match->data;
printf("rateest match ");
@@ -406,7 +407,7 @@ rateest_print(const void *ip, const struct xt_entry_match *match, bool numeric)
static void
rateest_save(const void *ip, const struct xt_entry_match *match)
{
- struct xt_rateest_match_info *info = (void *)match->data;
+ const struct xt_rateest_match_info *info = (const void *)match->data;
if (info->flags & XT_RATEEST_MATCH_REL) {
printf("--rateest1 %s ", info->name1);
diff --git a/extensions/libxt_state.c b/extensions/libxt_state.c
index 97afe45..248d71f 100644
--- a/extensions/libxt_state.c
+++ b/extensions/libxt_state.c
@@ -125,7 +125,7 @@ state_print(const void *ip,
const struct xt_entry_match *match,
bool numeric)
{
- struct xt_state_info *sinfo = (struct xt_state_info *)match->data;
+ const struct xt_state_info *sinfo = (const void *)match->data;
printf("state ");
state_print_state(sinfo->statemask);
@@ -133,7 +133,7 @@ state_print(const void *ip,
static void state_save(const void *ip, const struct xt_entry_match *match)
{
- struct xt_state_info *sinfo = (struct xt_state_info *)match->data;
+ const struct xt_state_info *sinfo = (const void *)match->data;
printf("--state ");
state_print_state(sinfo->statemask);
diff --git a/extensions/libxt_statistic.c b/extensions/libxt_statistic.c
index 139f878..4f661e8 100644
--- a/extensions/libxt_statistic.c
+++ b/extensions/libxt_statistic.c
@@ -148,7 +148,7 @@ static void
statistic_print(const void *ip, const struct xt_entry_match *match,
bool numeric)
{
- struct xt_statistic_info *info = (struct xt_statistic_info *)match->data;
+ const struct xt_statistic_info *info = (const void *)match->data;
printf("statistic ");
print_match(info, "");
@@ -156,7 +156,7 @@ statistic_print(const void *ip, const struct xt_entry_match *match,
static void statistic_save(const void *ip, const struct xt_entry_match *match)
{
- struct xt_statistic_info *info = (struct xt_statistic_info *)match->data;
+ const struct xt_statistic_info *info = (const void *)match->data;
print_match(info, "--");
}
diff --git a/extensions/libxt_time.c b/extensions/libxt_time.c
index f2db56f..6dc7431 100644
--- a/extensions/libxt_time.c
+++ b/extensions/libxt_time.c
@@ -406,7 +406,7 @@ static inline void divide_time(unsigned int fulltime, unsigned int *hours,
static void time_print(const void *ip, const struct xt_entry_match *match,
bool numeric)
{
- struct xt_time_info *info = (void *)match->data;
+ const struct xt_time_info *info = (const void *)match->data;
unsigned int h, m, s;
printf("TIME ");
--
1.6.2.2
next prev parent reply other threads:[~2009-05-03 19:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-03 19:54 iptables pull request Jan Engelhardt
2009-05-03 19:54 ` [PATCH 1/9] iptables: accept multiple IP address specifications for -s, -d Jan Engelhardt
2009-05-03 19:54 ` [PATCH 2/9] DNAT/SNAT: add manpage documentation for --persistent flag Jan Engelhardt
2009-05-03 19:54 ` [PATCH 3/9] extensions: remove redundant casts Jan Engelhardt
2009-05-03 19:54 ` [PATCH 4/9] extensions: switch numeric to bool Jan Engelhardt
2009-05-03 19:54 ` [PATCH 5/9] libxt_helper: fix invalid passed option to check_inverse Jan Engelhardt
2009-05-03 19:54 ` [PATCH 6/9] extensions: switch invert to bool Jan Engelhardt
2009-05-03 19:54 ` [PATCH 7/9] extensions: switch parse() return type " Jan Engelhardt
2009-05-03 19:54 ` Jan Engelhardt [this message]
2009-05-03 19:54 ` [PATCH 9/9] iptables: replace open-coded sizeof by ARRAY_SIZE Jan Engelhardt
2009-05-04 13:23 ` iptables pull request Pablo Neira Ayuso
2009-05-04 23:54 ` Jan Engelhardt
2009-05-05 13:26 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241380473-22262-9-git-send-email-jengelh@medozas.de \
--to=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).