From: Joe Perches <joe@perches.com>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 0/3] netfilter: Use pr_<level> and pr_fmt
Date: Thu, 11 Jun 2009 10:44:59 -0700 [thread overview]
Message-ID: <1244742299.30185.7.camel@Joe-Laptop.home> (raw)
In-Reply-To: <alpine.LSU.2.00.0906111303260.1795@fbirervta.pbzchgretzou.qr>
On Thu, 2009-06-11 at 13:04 +0200, Jan Engelhardt wrote:
> On Thursday 2009-06-11 09:40, Joe Perches wrote:
>
> >Many of the [wretched grammar removed] netfilter printk
> >calls do not have KERN_<level> prefixes.
[]
> >Remove the function names in printk strings and add
> >#define pr_fmt(fmt) "%s:%s " fmt, KBUILD_MODNAME, __func__
>
> Hm I had wished there was a better way than to replicate
> this define over all Netfilter files.
> Perhaps stuff it into an include.
Maybe standardize the netfilter includes a bit later?
Patrick, is this patch set concept acceptable at all?
prev parent reply other threads:[~2009-06-11 17:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 7:40 [PATCH 0/3] netfilter: Use pr_<level> and pr_fmt Joe Perches
2009-06-11 7:40 ` [PATCH 1/3] x_tables: Convert printk to pr_err Joe Perches
2009-06-13 10:35 ` Patrick McHardy
2009-06-11 7:40 ` [PATCH 2/3] net/netfilter: Convert printk uses to pr_<level> Joe Perches
2009-06-13 10:45 ` Patrick McHardy
2009-06-16 17:58 ` Joe Perches
2009-06-11 7:40 ` [PATCH 3/3] netfilter h323_asn1.c: convert PRINT to pr_info Joe Perches
2009-06-11 11:04 ` [PATCH 0/3] netfilter: Use pr_<level> and pr_fmt Jan Engelhardt
2009-06-11 17:44 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244742299.30185.7.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).