* [PATCH 0/8] Remove most uses of NIPQUAD and NIPQUAD_FMT
@ 2010-01-06 1:20 Joe Perches
2010-01-06 1:20 ` [PATCH 5/8] net/ipv4/netfilter/nf_nat_ftp.c: Convert NIPQUAD to %pI4 Joe Perches
2010-01-06 1:20 ` [PATCH 6/8] net/netfilter/ipvs/ip_vs_ftp.c: Use standardized format in sprintf Joe Perches
0 siblings, 2 replies; 17+ messages in thread
From: Joe Perches @ 2010-01-06 1:20 UTC (permalink / raw)
To: linux-kernel
Cc: James E.J. Bottomley, Greg Kroah-Hartman, Mark Fasheh,
Joel Becker, Patrick McHardy, David S. Miller, Alexey Kuznetsov,
Pekka Savola (ipv6), James Morris, Hideaki YOSHIFUJI,
Wensong Zhang, Simon Horman, Julian Anastasov, Andy Grover,
J. Bruce Fields, Neil Brown, Trond Myklebust, linux-scsi, devel,
ocfs2-devel, netfilter-devel, netfilter, coreteam, netdev,
lvs-devel, rds
Convert them to the %pI4 format extension where possible
Only a couple uses are left in netfilter.
Joe Perches (8):
drivers/scsi: Remove uses of NIPQUAD, use %pI4
drivers/staging/pohmelfs/inode.c: Remove uses of NIPQUAD, use %pI4
net/rds: Remove uses of NIPQUAD, use %pI4
net/sunrpc: Remove uses of NIPQUAD, use %pI4
net/ipv4/netfilter/nf_nat_ftp.c: Convert NIPQUAD to %pI4
net/netfilter/ipvs/ip_vs_ftp.c: Use standardized format in sprintf
fs/ocfs2/cluster/tcp.c: Remove use of NIPQUAD, use %pI4
drivers/firmware/iscsi_ibft.c: Remove NIPQUAD_FMT, use %pI4
drivers/firmware/iscsi_ibft.c | 8 +++-----
drivers/scsi/bnx2i/bnx2i_iscsi.c | 4 ++--
drivers/scsi/cxgb3i/cxgb3i_iscsi.c | 5 ++---
drivers/scsi/cxgb3i/cxgb3i_offload.c | 7 ++++---
drivers/staging/pohmelfs/inode.c | 3 +--
fs/ocfs2/cluster/tcp.c | 4 ++--
net/ipv4/netfilter/nf_nat_ftp.c | 2 +-
net/netfilter/ipvs/ip_vs_ftp.c | 2 +-
net/rds/tcp_connect.c | 7 +++----
net/rds/tcp_listen.c | 6 +++---
net/rds/tcp_send.c | 4 ++--
net/sunrpc/xprtrdma/transport.c | 3 +--
net/sunrpc/xprtsock.c | 5 ++---
13 files changed, 27 insertions(+), 33 deletions(-)
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 5/8] net/ipv4/netfilter/nf_nat_ftp.c: Convert NIPQUAD to %pI4
2010-01-06 1:20 [PATCH 0/8] Remove most uses of NIPQUAD and NIPQUAD_FMT Joe Perches
@ 2010-01-06 1:20 ` Joe Perches
2010-01-06 19:23 ` [PATCH v2 5/8] net/ipv4/netfilter/nf_nat_ftp.c: Remove (*mangle[]) array and functions, use %pI4 Joe Perches
2010-01-06 1:20 ` [PATCH 6/8] net/netfilter/ipvs/ip_vs_ftp.c: Use standardized format in sprintf Joe Perches
1 sibling, 1 reply; 17+ messages in thread
From: Joe Perches @ 2010-01-06 1:20 UTC (permalink / raw)
To: linux-kernel
Cc: Patrick McHardy, David S. Miller, Alexey Kuznetsov,
Pekka Savola (ipv6), James Morris, Hideaki YOSHIFUJI,
netfilter-devel, netfilter, coreteam, netdev
Signed-off-by: Joe Perches <joe@perches.com>
---
net/ipv4/netfilter/nf_nat_ftp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/netfilter/nf_nat_ftp.c b/net/ipv4/netfilter/nf_nat_ftp.c
index a1d5d58..d1c5afc 100644
--- a/net/ipv4/netfilter/nf_nat_ftp.c
+++ b/net/ipv4/netfilter/nf_nat_ftp.c
@@ -59,7 +59,7 @@ mangle_eprt_packet(struct sk_buff *skb,
{
char buffer[sizeof("|1|255.255.255.255|65535|")];
- sprintf(buffer, "|1|%u.%u.%u.%u|%u|", NIPQUAD(newip), port);
+ sprintf(buffer, "|1|%pI4|%u|", &newip, port);
pr_debug("calling nf_nat_mangle_tcp_packet\n");
--
1.6.6.rc0.57.gad7a
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 6/8] net/netfilter/ipvs/ip_vs_ftp.c: Use standardized format in sprintf
2010-01-06 1:20 [PATCH 0/8] Remove most uses of NIPQUAD and NIPQUAD_FMT Joe Perches
2010-01-06 1:20 ` [PATCH 5/8] net/ipv4/netfilter/nf_nat_ftp.c: Convert NIPQUAD to %pI4 Joe Perches
@ 2010-01-06 1:20 ` Joe Perches
2010-01-06 2:34 ` Simon Horman
1 sibling, 1 reply; 17+ messages in thread
From: Joe Perches @ 2010-01-06 1:20 UTC (permalink / raw)
To: linux-kernel
Cc: Wensong Zhang, Simon Horman, Julian Anastasov, Patrick McHardy,
David S. Miller, netdev, lvs-devel, netfilter-devel, netfilter,
coreteam
Use the same format string as net/ipv4/netfilter/nf_nat_ftp.c
to encode an ipv4 address and port.
Both uses should be a single common function.
Signed-off-by: Joe Perches <joe@perches.com>
---
net/netfilter/ipvs/ip_vs_ftp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c
index 33e2c79..73f38ea 100644
--- a/net/netfilter/ipvs/ip_vs_ftp.c
+++ b/net/netfilter/ipvs/ip_vs_ftp.c
@@ -208,7 +208,7 @@ static int ip_vs_ftp_out(struct ip_vs_app *app, struct ip_vs_conn *cp,
*/
from.ip = n_cp->vaddr.ip;
port = n_cp->vport;
- sprintf(buf, "%d,%d,%d,%d,%d,%d", NIPQUAD(from.ip),
+ sprintf(buf, "%u,%u,%u,%u,%u,%u", NIPQUAD(from.ip),
(ntohs(port)>>8)&255, ntohs(port)&255);
buf_len = strlen(buf);
--
1.6.6.rc0.57.gad7a
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 6/8] net/netfilter/ipvs/ip_vs_ftp.c: Use standardized format in sprintf
2010-01-06 1:20 ` [PATCH 6/8] net/netfilter/ipvs/ip_vs_ftp.c: Use standardized format in sprintf Joe Perches
@ 2010-01-06 2:34 ` Simon Horman
2010-01-11 10:54 ` Patrick McHardy
0 siblings, 1 reply; 17+ messages in thread
From: Simon Horman @ 2010-01-06 2:34 UTC (permalink / raw)
To: Joe Perches
Cc: linux-kernel, Wensong Zhang, Julian Anastasov, Patrick McHardy,
David S. Miller, netdev, lvs-devel, netfilter-devel, netfilter,
coreteam
On Tue, Jan 05, 2010 at 05:20:18PM -0800, Joe Perches wrote:
> Use the same format string as net/ipv4/netfilter/nf_nat_ftp.c
> to encode an ipv4 address and port.
>
> Both uses should be a single common function.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Simon Horman <horms@verge.net.au>
> ---
> net/netfilter/ipvs/ip_vs_ftp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c
> index 33e2c79..73f38ea 100644
> --- a/net/netfilter/ipvs/ip_vs_ftp.c
> +++ b/net/netfilter/ipvs/ip_vs_ftp.c
> @@ -208,7 +208,7 @@ static int ip_vs_ftp_out(struct ip_vs_app *app, struct ip_vs_conn *cp,
> */
> from.ip = n_cp->vaddr.ip;
> port = n_cp->vport;
> - sprintf(buf, "%d,%d,%d,%d,%d,%d", NIPQUAD(from.ip),
> + sprintf(buf, "%u,%u,%u,%u,%u,%u", NIPQUAD(from.ip),
> (ntohs(port)>>8)&255, ntohs(port)&255);
> buf_len = strlen(buf);
>
> --
> 1.6.6.rc0.57.gad7a
>
> --
> To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 5/8] net/ipv4/netfilter/nf_nat_ftp.c: Remove (*mangle[]) array and functions, use %pI4
2010-01-06 1:20 ` [PATCH 5/8] net/ipv4/netfilter/nf_nat_ftp.c: Convert NIPQUAD to %pI4 Joe Perches
@ 2010-01-06 19:23 ` Joe Perches
2010-01-11 10:51 ` Patrick McHardy
0 siblings, 1 reply; 17+ messages in thread
From: Joe Perches @ 2010-01-06 19:23 UTC (permalink / raw)
To: linux-kernel
Cc: Patrick McHardy, David S. Miller, Alexey Kuznetsov,
Pekka Savola (ipv6), James Morris, Hideaki YOSHIFUJI,
netfilter-devel, netfilter, coreteam, netdev
These functions merely exist to format a buffer and call
nf_nat_mangle_tcp_packet.
Format the buffer and perform the call in nf_nat_ftp instead.
Use %pI4 for the IP address.
Saves ~600 bytes of text
old:
$ size net/ipv4/netfilter/nf_nat_ftp.o
text data bss dec hex filename
2187 160 408 2755 ac3 net/ipv4/netfilter/nf_nat_ftp.o
new:
$ size net/ipv4/netfilter/nf_nat_ftp.o
text data bss dec hex filename
1532 112 288 1932 78c net/ipv4/netfilter/nf_nat_ftp.o
Signed-off-by: Joe Perches <joe@perches.com>
net/ipv4/netfilter/nf_nat_ftp.c | 105 +++++++++++++--------------------------
1 files changed, 35 insertions(+), 70 deletions(-)
diff --git a/net/ipv4/netfilter/nf_nat_ftp.c b/net/ipv4/netfilter/nf_nat_ftp.c
index a1d5d58..86e0e84 100644
--- a/net/ipv4/netfilter/nf_nat_ftp.c
+++ b/net/ipv4/netfilter/nf_nat_ftp.c
@@ -27,76 +27,29 @@ MODULE_ALIAS("ip_nat_ftp");
/* FIXME: Time out? --RR */
-static int
-mangle_rfc959_packet(struct sk_buff *skb,
- __be32 newip,
- u_int16_t port,
- unsigned int matchoff,
- unsigned int matchlen,
- struct nf_conn *ct,
- enum ip_conntrack_info ctinfo)
+static int nf_nat_ftp_fmt_cmd(enum nf_ct_ftp_type type,
+ char *buffer, size_t buflen,
+ __be32 addr, u16 port)
{
- char buffer[sizeof("nnn,nnn,nnn,nnn,nnn,nnn")];
-
- sprintf(buffer, "%u,%u,%u,%u,%u,%u",
- NIPQUAD(newip), port>>8, port&0xFF);
-
- pr_debug("calling nf_nat_mangle_tcp_packet\n");
-
- return nf_nat_mangle_tcp_packet(skb, ct, ctinfo, matchoff,
- matchlen, buffer, strlen(buffer));
-}
-
-/* |1|132.235.1.2|6275| */
-static int
-mangle_eprt_packet(struct sk_buff *skb,
- __be32 newip,
- u_int16_t port,
- unsigned int matchoff,
- unsigned int matchlen,
- struct nf_conn *ct,
- enum ip_conntrack_info ctinfo)
-{
- char buffer[sizeof("|1|255.255.255.255|65535|")];
-
- sprintf(buffer, "|1|%u.%u.%u.%u|%u|", NIPQUAD(newip), port);
-
- pr_debug("calling nf_nat_mangle_tcp_packet\n");
-
- return nf_nat_mangle_tcp_packet(skb, ct, ctinfo, matchoff,
- matchlen, buffer, strlen(buffer));
-}
-
-/* |1|132.235.1.2|6275| */
-static int
-mangle_epsv_packet(struct sk_buff *skb,
- __be32 newip,
- u_int16_t port,
- unsigned int matchoff,
- unsigned int matchlen,
- struct nf_conn *ct,
- enum ip_conntrack_info ctinfo)
-{
- char buffer[sizeof("|||65535|")];
-
- sprintf(buffer, "|||%u|", port);
-
- pr_debug("calling nf_nat_mangle_tcp_packet\n");
+ switch (type) {
+ case NF_CT_FTP_PORT:
+ case NF_CT_FTP_PASV:
+ return snprintf(buffer, buflen, "%u,%u,%u,%u,%u,%u",
+ ((unsigned char *)&addr)[0],
+ ((unsigned char *)&addr)[1],
+ ((unsigned char *)&addr)[2],
+ ((unsigned char *)&addr)[3],
+ port >> 8,
+ port & 0xFF);
+ case NF_CT_FTP_EPRT:
+ return snprintf(buffer, buflen, "|1|%pI4|%u|", &addr, port);
+ case NF_CT_FTP_EPSV:
+ return snprintf(buffer, buflen, "|||%u|", port);
+ }
- return nf_nat_mangle_tcp_packet(skb, ct, ctinfo, matchoff,
- matchlen, buffer, strlen(buffer));
+ return 0;
}
-static int (*mangle[])(struct sk_buff *, __be32, u_int16_t,
- unsigned int, unsigned int, struct nf_conn *,
- enum ip_conntrack_info)
-= {
- [NF_CT_FTP_PORT] = mangle_rfc959_packet,
- [NF_CT_FTP_PASV] = mangle_rfc959_packet,
- [NF_CT_FTP_EPRT] = mangle_eprt_packet,
- [NF_CT_FTP_EPSV] = mangle_epsv_packet
-};
-
/* So, this packet has hit the connection tracking matching code.
Mangle it, and change the expectation to match the new version. */
static unsigned int nf_nat_ftp(struct sk_buff *skb,
@@ -110,6 +63,8 @@ static unsigned int nf_nat_ftp(struct sk_buff *skb,
u_int16_t port;
int dir = CTINFO2DIR(ctinfo);
struct nf_conn *ct = exp->master;
+ char buffer[sizeof("|1|255.255.255.255|65535|")];
+ unsigned int buflen;
pr_debug("FTP_NAT: type %i, off %u len %u\n", type, matchoff, matchlen);
@@ -132,11 +87,21 @@ static unsigned int nf_nat_ftp(struct sk_buff *skb,
if (port == 0)
return NF_DROP;
- if (!mangle[type](skb, newip, port, matchoff, matchlen, ct, ctinfo)) {
- nf_ct_unexpect_related(exp);
- return NF_DROP;
- }
+ buflen = nf_nat_ftp_fmt_cmd(type, buffer, sizeof(buffer), newip, port);
+ if (!buflen)
+ goto out;
+
+ pr_debug("calling nf_nat_mangle_tcp_packet\n");
+
+ if (!nf_nat_mangle_tcp_packet(skb, ct, ctinfo, matchoff,
+ matchlen, buffer, buflen))
+ goto out;
+
return NF_ACCEPT;
+
+out:
+ nf_ct_unexpect_related(exp);
+ return NF_DROP;
}
static void __exit nf_nat_ftp_fini(void)
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2 5/8] net/ipv4/netfilter/nf_nat_ftp.c: Remove (*mangle[]) array and functions, use %pI4
2010-01-06 19:23 ` [PATCH v2 5/8] net/ipv4/netfilter/nf_nat_ftp.c: Remove (*mangle[]) array and functions, use %pI4 Joe Perches
@ 2010-01-11 10:51 ` Patrick McHardy
2010-01-11 11:09 ` [PATCH] MAINTAINERS: netfilter - Remove netfilter and netfilter-core lists Joe Perches
0 siblings, 1 reply; 17+ messages in thread
From: Patrick McHardy @ 2010-01-11 10:51 UTC (permalink / raw)
To: Joe Perches
Cc: linux-kernel, David S. Miller, Alexey Kuznetsov,
Pekka Savola (ipv6), James Morris, Hideaki YOSHIFUJI,
netfilter-devel, netfilter, coreteam, netdev
Joe Perches wrote:
> These functions merely exist to format a buffer and call
> nf_nat_mangle_tcp_packet.
>
> Format the buffer and perform the call in nf_nat_ftp instead.
>
> Use %pI4 for the IP address.
>
> Saves ~600 bytes of text
>
> old:
> $ size net/ipv4/netfilter/nf_nat_ftp.o
> text data bss dec hex filename
> 2187 160 408 2755 ac3 net/ipv4/netfilter/nf_nat_ftp.o
> new:
> $ size net/ipv4/netfilter/nf_nat_ftp.o
> text data bss dec hex filename
> 1532 112 288 1932 78c net/ipv4/netfilter/nf_nat_ftp.o
Applied, thanks. BTW, its enough to CC netfilter-devel and optionally
netdev on patches, netfilter and netfilter-core are unnecessary.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 6/8] net/netfilter/ipvs/ip_vs_ftp.c: Use standardized format in sprintf
2010-01-06 2:34 ` Simon Horman
@ 2010-01-11 10:54 ` Patrick McHardy
0 siblings, 0 replies; 17+ messages in thread
From: Patrick McHardy @ 2010-01-11 10:54 UTC (permalink / raw)
To: Simon Horman
Cc: Joe Perches, linux-kernel, Wensong Zhang, Julian Anastasov,
David S. Miller, netdev, lvs-devel, netfilter-devel, netfilter,
coreteam
Simon Horman wrote:
> On Tue, Jan 05, 2010 at 05:20:18PM -0800, Joe Perches wrote:
>> Use the same format string as net/ipv4/netfilter/nf_nat_ftp.c
>> to encode an ipv4 address and port.
>>
>> Both uses should be a single common function.
>>
>> Signed-off-by: Joe Perches <joe@perches.com>
>
> Acked-by: Simon Horman <horms@verge.net.au>
Applied, thanks.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH] MAINTAINERS: netfilter - Remove netfilter and netfilter-core lists
2010-01-11 10:51 ` Patrick McHardy
@ 2010-01-11 11:09 ` Joe Perches
2010-01-11 11:14 ` Patrick McHardy
0 siblings, 1 reply; 17+ messages in thread
From: Joe Perches @ 2010-01-11 11:09 UTC (permalink / raw)
To: Patrick McHardy; +Cc: linux-kernel, netfilter-devel, netdev
On Mon, 2010-01-11 at 11:51 +0100, Patrick McHardy wrote:
> it's enough to CC netfilter-devel and optionally
> netdev on patches, netfilter and netfilter-core are unnecessary.
Signed-off-by: Joe Perches <joe@perches.com>
diff --git a/MAINTAINERS b/MAINTAINERS
index 745643b..860d04f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3742,8 +3742,6 @@ P: Harald Welte
P: Jozsef Kadlecsik
M: Patrick McHardy <kaber@trash.net>
L: netfilter-devel@vger.kernel.org
-L: netfilter@vger.kernel.org
-L: coreteam@netfilter.org
W: http://www.netfilter.org/
W: http://www.iptables.org/
T: git git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-2.6.git
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH] MAINTAINERS: netfilter - Remove netfilter and netfilter-core lists
2010-01-11 11:09 ` [PATCH] MAINTAINERS: netfilter - Remove netfilter and netfilter-core lists Joe Perches
@ 2010-01-11 11:14 ` Patrick McHardy
2010-01-11 11:27 ` [PATCH V2] MAINTAINERS: netfilter - Document netfilter and netfilter-core lists purposes Joe Perches
0 siblings, 1 reply; 17+ messages in thread
From: Patrick McHardy @ 2010-01-11 11:14 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-kernel, netfilter-devel, netdev
Joe Perches wrote:
> On Mon, 2010-01-11 at 11:51 +0100, Patrick McHardy wrote:
>> it's enough to CC netfilter-devel and optionally
>> netdev on patches, netfilter and netfilter-core are unnecessary.
>
> Signed-off-by: Joe Perches <joe@perches.com>
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 745643b..860d04f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3742,8 +3742,6 @@ P: Harald Welte
> P: Jozsef Kadlecsik
> M: Patrick McHardy <kaber@trash.net>
> L: netfilter-devel@vger.kernel.org
> -L: netfilter@vger.kernel.org
> -L: coreteam@netfilter.org
A comment stating the purpose of each list would be more approriate IMO.
netfilter-devel is for developers and patches, netfilter is for users
and netfilter-core is only meant to reach the coreteam privately.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH V2] MAINTAINERS: netfilter - Document netfilter and netfilter-core lists purposes
2010-01-11 11:14 ` Patrick McHardy
@ 2010-01-11 11:27 ` Joe Perches
2010-01-11 11:31 ` Jan Engelhardt
0 siblings, 1 reply; 17+ messages in thread
From: Joe Perches @ 2010-01-11 11:27 UTC (permalink / raw)
To: Patrick McHardy; +Cc: linux-kernel, netfilter-devel, netdev
> On Mon, 2010-01-11 at 11:51 +0100, Patrick McHardy wrote:
> it's enough to CC netfilter-devel and optionally
> netdev on patches, netfilter and netfilter-core are unnecessary.
> On Mon, 2010-01-11 at 12:14 +0100, Patrick McHardy wrote:
> A comment stating the purpose of each list would be more appropriate.
> netfilter-devel is for developers and patches, netfilter is for users
> and netfilter-core is only meant to reach the coreteam privately.
Adding "subscribers-only" after the list address stops
scripts/get_maintainer.pl from including the address
unless --s is used. Doesn't matter if the list really
is subscribers-only or not.
Signed-off-by: Joe Perches <joe@perches.com>
diff --git a/MAINTAINERS b/MAINTAINERS
index 745643b..ea5ddc8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3742,8 +3742,8 @@ P: Harald Welte
P: Jozsef Kadlecsik
M: Patrick McHardy <kaber@trash.net>
L: netfilter-devel@vger.kernel.org
-L: netfilter@vger.kernel.org
-L: coreteam@netfilter.org
+L: netfilter@vger.kernel.org for user issues, not subscribers-only
+L: coreteam@netfilter.org for private emails, not subscribers-only
W: http://www.netfilter.org/
W: http://www.iptables.org/
T: git git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-2.6.git
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH V2] MAINTAINERS: netfilter - Document netfilter and netfilter-core lists purposes
2010-01-11 11:27 ` [PATCH V2] MAINTAINERS: netfilter - Document netfilter and netfilter-core lists purposes Joe Perches
@ 2010-01-11 11:31 ` Jan Engelhardt
2010-01-11 11:43 ` Joe Perches
2010-01-12 18:46 ` [PATCH V3] MAINTAINERS: Document list types, add "A:" section type, update NETFILTER Joe Perches
0 siblings, 2 replies; 17+ messages in thread
From: Jan Engelhardt @ 2010-01-11 11:31 UTC (permalink / raw)
To: Joe Perches; +Cc: Patrick McHardy, linux-kernel, netfilter-devel, netdev
On Monday 2010-01-11 12:27, Joe Perches wrote:
>Adding "subscribers-only" after the list address stops
>scripts/get_maintainer.pl from including the address
>unless --s is used. Doesn't matter if the list really
>is subscribers-only or not.
>
>Signed-off-by: Joe Perches <joe@perches.com>
>
>+++ b/MAINTAINERS
>@@ -3742,8 +3742,8 @@ P: Harald Welte
> P: Jozsef Kadlecsik
> M: Patrick McHardy <kaber@trash.net>
> L: netfilter-devel@vger.kernel.org
>-L: netfilter@vger.kernel.org
>-L: coreteam@netfilter.org
>+L: netfilter@vger.kernel.org for user issues, not subscribers-only
>+L: coreteam@netfilter.org for private emails, not subscribers-only
> W: http://www.netfilter.org/
This is a little stab-through-the-back -
rather than "subscribers-only", I'd use "subscriber-free" or FFA,
or just leave it blank and use "subscribers-only" instead
for these.
L: netfilter-devel@vger.kernel.org
L: coreteam@netfilter.org subscribers-only
> W: http://www.iptables.org/
netfilter.org/
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH V2] MAINTAINERS: netfilter - Document netfilter and netfilter-core lists purposes
2010-01-11 11:31 ` Jan Engelhardt
@ 2010-01-11 11:43 ` Joe Perches
2010-01-12 18:46 ` [PATCH V3] MAINTAINERS: Document list types, add "A:" section type, update NETFILTER Joe Perches
1 sibling, 0 replies; 17+ messages in thread
From: Joe Perches @ 2010-01-11 11:43 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: Patrick McHardy, linux-kernel, netfilter-devel, netdev
On Mon, 2010-01-11 at 12:31 +0100, Jan Engelhardt wrote:
> On Monday 2010-01-11 12:27, Joe Perches wrote:
> >Adding "subscribers-only" after the list address stops
> >scripts/get_maintainer.pl from including the address
> >unless --s is used. Doesn't matter if the list really
> >is subscribers-only or not.
> This is a little stab-through-the-back -
> rather than "subscribers-only", I'd use "subscriber-free" or FFA,
> or just leave it blank and use "subscribers-only" instead
> for these.
You're welcome and free to change the script
and MAINTAINERS.
I think this works well-enough though.
cheers, Joe
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH V3] MAINTAINERS: Document list types, add "A:" section type, update NETFILTER
2010-01-11 11:31 ` Jan Engelhardt
2010-01-11 11:43 ` Joe Perches
@ 2010-01-12 18:46 ` Joe Perches
2010-01-13 15:13 ` Stefan Richter
1 sibling, 1 reply; 17+ messages in thread
From: Joe Perches @ 2010-01-12 18:46 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: Patrick McHardy, linux-kernel, netfilter-devel, netdev
On Mon, 2010-01-11 at 12:31 +0100, Jan Engelhardt wrote:
> This is a little stab-through-the-back -
> rather than "subscribers-only", I'd use "subscriber-free" or FFA,
> or just leave it blank and use "subscribers-only" instead
> for these.
Here's another option:
Signed-off-by: Joe Perches <joe@perches.com>
diff --git a/MAINTAINERS b/MAINTAINERS
index 745643b..8abf3be 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -69,7 +69,20 @@ Descriptions of section entries:
P: Person (obsolete)
M: Mail patches to: FullName <address@domain>
- L: Mailing list that is relevant to this area
+ L: Mailing list that should receive patches, bug reports or
+ developer questions.
+ Mailing lists can be one of:
+ (open list): the default, unmarked case
+ Subscription to the list is not required, but emails
+ may be rejected by spam filters without notification.
+ (moderated for non-subscribers):
+ emails from non-subscribers are actively filtered
+ and may be arbitrarily delayed or rejected without
+ notification if off-topic. Upon receipt of the email,
+ a moderation notification email may be automatically
+ sent by the list manager.
+ (subscribers-only):
+ emails from non-subscribers are not accepted.
W: Web-page with status/info
T: SCM tree type and location. Type is one of: git, hg, quilt, stgit.
S: Status, one of the following:
@@ -102,6 +115,7 @@ Descriptions of section entries:
matches patches or files that contain one or more of the words
printk, pr_info or pr_err
One regex pattern per line. Multiple K: lines acceptable.
+ A: Additional useful unstructured information.
Note: For the hard of thinking, this list is meant to remain in alphabetical
order. If you could add yourselves to it in alphabetical order that would be
@@ -3742,8 +3756,8 @@ P: Harald Welte
P: Jozsef Kadlecsik
M: Patrick McHardy <kaber@trash.net>
L: netfilter-devel@vger.kernel.org
-L: netfilter@vger.kernel.org
-L: coreteam@netfilter.org
+A: netfilter@vger.kernel.org (email list for user issues)
+A: coreteam@netfilter.org (private emails to core developers)
W: http://www.netfilter.org/
W: http://www.iptables.org/
T: git git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-2.6.git
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH V3] MAINTAINERS: Document list types, add "A:" section type, update NETFILTER
2010-01-12 18:46 ` [PATCH V3] MAINTAINERS: Document list types, add "A:" section type, update NETFILTER Joe Perches
@ 2010-01-13 15:13 ` Stefan Richter
2010-01-13 16:15 ` Joe Perches
0 siblings, 1 reply; 17+ messages in thread
From: Stefan Richter @ 2010-01-13 15:13 UTC (permalink / raw)
To: Joe Perches
Cc: Jan Engelhardt, Patrick McHardy, linux-kernel, netfilter-devel,
netdev
Joe Perches wrote:
> + A: Additional useful unstructured information.
Can be implemented with a level of indirection via the W: entries.
--
Stefan Richter
-=====-==-=- ---= -==-=
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH V3] MAINTAINERS: Document list types, add "A:" section type, update NETFILTER
2010-01-13 15:13 ` Stefan Richter
@ 2010-01-13 16:15 ` Joe Perches
2010-01-13 17:10 ` Stefan Richter
0 siblings, 1 reply; 17+ messages in thread
From: Joe Perches @ 2010-01-13 16:15 UTC (permalink / raw)
To: Stefan Richter
Cc: Jan Engelhardt, Patrick McHardy, linux-kernel, netfilter-devel,
netdev
On Wed, 2010-01-13 at 16:13 +0100, Stefan Richter wrote:
> Joe Perches wrote:
> > + A: Additional useful unstructured information.
> Can be implemented with a level of indirection via the W: entries.
Mailing lists aren't web addresses.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH V3] MAINTAINERS: Document list types, add "A:" section type, update NETFILTER
2010-01-13 16:15 ` Joe Perches
@ 2010-01-13 17:10 ` Stefan Richter
2010-01-15 20:03 ` Pavel Machek
0 siblings, 1 reply; 17+ messages in thread
From: Stefan Richter @ 2010-01-13 17:10 UTC (permalink / raw)
To: Joe Perches
Cc: Jan Engelhardt, Patrick McHardy, linux-kernel, netfilter-devel,
netdev
Joe Perches wrote:
> On Wed, 2010-01-13 at 16:13 +0100, Stefan Richter wrote:
>> Joe Perches wrote:
>> > + A: Additional useful unstructured information.
>> Can be implemented with a level of indirection via the W: entries.
>
> Mailing lists aren't web addresses.
Project web sites typically contain contact pages (which is what you
used the first two proposed A: entries for --- contacts that apparently
do not play a role for patch submission), and web sites can carry any
other "unstructured information".
Keep redundancy low.
--
Stefan Richter
-=====-==-=- ---= -==-=
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH V3] MAINTAINERS: Document list types, add "A:" section type, update NETFILTER
2010-01-13 17:10 ` Stefan Richter
@ 2010-01-15 20:03 ` Pavel Machek
0 siblings, 0 replies; 17+ messages in thread
From: Pavel Machek @ 2010-01-15 20:03 UTC (permalink / raw)
To: Stefan Richter
Cc: Joe Perches, Jan Engelhardt, Patrick McHardy, linux-kernel,
netfilter-devel, netdev
On Wed 2010-01-13 18:10:28, Stefan Richter wrote:
> Joe Perches wrote:
> > On Wed, 2010-01-13 at 16:13 +0100, Stefan Richter wrote:
> >> Joe Perches wrote:
> >> > + A: Additional useful unstructured information.
> >> Can be implemented with a level of indirection via the W: entries.
> >
> > Mailing lists aren't web addresses.
>
> Project web sites typically contain contact pages (which is what you
> used the first two proposed A: entries for --- contacts that apparently
> do not play a role for patch submission), and web sites can carry any
> other "unstructured information".
>
> Keep redundancy low.
Well, I'd say that kernel maintainance info should be
kept... well... in kernel...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2010-01-15 20:03 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-06 1:20 [PATCH 0/8] Remove most uses of NIPQUAD and NIPQUAD_FMT Joe Perches
2010-01-06 1:20 ` [PATCH 5/8] net/ipv4/netfilter/nf_nat_ftp.c: Convert NIPQUAD to %pI4 Joe Perches
2010-01-06 19:23 ` [PATCH v2 5/8] net/ipv4/netfilter/nf_nat_ftp.c: Remove (*mangle[]) array and functions, use %pI4 Joe Perches
2010-01-11 10:51 ` Patrick McHardy
2010-01-11 11:09 ` [PATCH] MAINTAINERS: netfilter - Remove netfilter and netfilter-core lists Joe Perches
2010-01-11 11:14 ` Patrick McHardy
2010-01-11 11:27 ` [PATCH V2] MAINTAINERS: netfilter - Document netfilter and netfilter-core lists purposes Joe Perches
2010-01-11 11:31 ` Jan Engelhardt
2010-01-11 11:43 ` Joe Perches
2010-01-12 18:46 ` [PATCH V3] MAINTAINERS: Document list types, add "A:" section type, update NETFILTER Joe Perches
2010-01-13 15:13 ` Stefan Richter
2010-01-13 16:15 ` Joe Perches
2010-01-13 17:10 ` Stefan Richter
2010-01-15 20:03 ` Pavel Machek
2010-01-06 1:20 ` [PATCH 6/8] net/netfilter/ipvs/ip_vs_ftp.c: Use standardized format in sprintf Joe Perches
2010-01-06 2:34 ` Simon Horman
2010-01-11 10:54 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).