From: Jon Masters <jonathan@jonmasters.org>
To: Patrick McHardy <kaber@trash.net>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
netfilter-devel@vger.kernel.org
Subject: Re: PROBLEM: reproducible crash KVM+nf_conntrack all recent 2.6 kernels
Date: Fri, 29 Jan 2010 03:42:45 -0500 [thread overview]
Message-ID: <1264754565.2793.405.camel@tonnant> (raw)
In-Reply-To: <1264727492.2793.207.camel@tonnant>
Hi,
So I did some poking (still trying to figure out netfilter a little
internally) and looked over the handling of connection tracking. The
oops reports I have been getting generally lie in __nf_conntrack_find,
specifically within a hlist iterator that looks up the information for
the current connection in a per-net namespace hashtable (under RCU, it's
been locked already by the time we get in here). Here's the piece:
hlist_nulls_for_each_entry_rcu(h, n, &net->ct.hash[hash],
hnnode) {
if (nf_ct_tuple_equal(tuple, &h->tuple)) {
NF_CT_STAT_INC(net, found);
local_bh_enable();
return h;
}
NF_CT_STAT_INC(net, searched);
}
Instrumenting the kernel at the moment and then setting up more of a
debugging environment to poke at what goes wrong here. Perhaps there's
some broken RCU assumption - I just spent the last few hours reading
over netfilter source and Paul's RCU docs again to brush up.
Perhaps you netdev folks can let me know if there's a handy netfilter
debugging guide somewhere.
Jon.
next prev parent reply other threads:[~2010-01-29 8:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 5:45 PROBLEM: reproducible crash KVM+nf_conntrack all recent 2.6 kernels Jon Masters
2010-01-28 5:59 ` Jon Masters
2010-01-28 12:19 ` Patrick McHardy
2010-01-28 21:05 ` Jon Masters
2010-01-28 21:49 ` Jon Masters
2010-01-28 23:21 ` Jon Masters
2010-01-29 1:11 ` Jon Masters
2010-01-29 8:42 ` Jon Masters [this message]
2010-01-29 9:10 ` Eric Dumazet
2010-01-29 10:57 ` Jon Masters
2010-01-29 21:51 ` Jon Masters
2010-01-28 7:20 ` Jon Masters
2010-01-28 8:07 ` Jon Masters
-- strict thread matches above, loose matches on Subject: below --
2010-01-28 9:19 Alexey Dobriyan
2010-01-28 11:21 ` Jon Masters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264754565.2793.405.camel@tonnant \
--to=jonathan@jonmasters.org \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).