From: Jon Masters <jonathan@jonmasters.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Patrick McHardy <kaber@trash.net>,
davem@davemloft.net, eric.dumazet@gmail.com,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH for 2.6.33] conntrack: restrict runtime hashsize modifications
Date: Thu, 04 Feb 2010 15:23:34 -0500 [thread overview]
Message-ID: <1265315014.2861.531.camel@tonnant> (raw)
In-Reply-To: <20100204194744.GA4185@x200>
On Thu, 2010-02-04 at 21:47 +0200, Alexey Dobriyan wrote:
> On Thu, Feb 04, 2010 at 06:04:34PM +0100, Patrick McHardy wrote:
> > Patrick McHardy wrote:
> > > Alexey Dobriyan wrote:
> > Additionally I removed reinitializing the hash random value when
> > changing the hash size since that also requires to rehash in all
> > namespaces.
>
> I'm not fond of this, because we're not even closely going to allow changing
> hashtable size per-netns. As such having actual per-netns hashtable size
> just slows down everything.
Are you sure, as compared with a shared global size that this is really
going to slow things down all that much? We already need to poke in that
struct to pull out various things just hash. I haven't profiled to see.
Jon.
next prev parent reply other threads:[~2010-02-04 20:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 20:39 [PATCH for 2.6.33] conntrack: restrict runtime hashsize modifications Alexey Dobriyan
2010-02-03 20:50 ` Jon Masters
2010-02-04 16:18 ` Patrick McHardy
2010-02-04 16:27 ` Patrick McHardy
2010-02-04 20:18 ` Jon Masters
2010-02-05 10:00 ` Patrick McHardy
2010-02-05 10:14 ` Jon Masters
2010-02-05 10:21 ` Patrick McHardy
2010-02-04 17:04 ` Patrick McHardy
2010-02-04 19:47 ` Alexey Dobriyan
2010-02-04 20:23 ` Jon Masters [this message]
2010-02-05 10:00 ` Patrick McHardy
2010-02-05 10:11 ` Jon Masters
2010-02-05 10:19 ` Patrick McHardy
2010-02-05 11:16 ` Patrick McHardy
2010-02-05 11:19 ` Alexey Dobriyan
2010-02-05 11:22 ` Patrick McHardy
2010-02-05 11:25 ` Patrick McHardy
2010-02-05 11:51 ` Jon Masters
2010-02-05 11:23 ` Alexey Dobriyan
2010-02-05 22:04 ` Alexey Dobriyan
2010-02-08 13:34 ` Patrick McHardy
2010-02-08 14:35 ` Patrick McHardy
2010-02-04 20:20 ` Jon Masters
2010-02-05 10:03 ` Patrick McHardy
2010-02-05 10:12 ` Jon Masters
2010-02-05 10:21 ` Patrick McHardy
2010-02-04 17:26 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265315014.2861.531.camel@tonnant \
--to=jonathan@jonmasters.org \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).