netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH 1/7] netfilter: ebtables: abort if next_offset is too small
Date: Fri,  5 Feb 2010 02:43:09 +0100	[thread overview]
Message-ID: <1265334195-28120-2-git-send-email-fw@strlen.de> (raw)
In-Reply-To: <1265334195-28120-1-git-send-email-fw@strlen.de>

next_offset must be > 0, otherwise this loops forever.
The offset also contains the size of the ebt_entry structure
itself, so anything smaller is invalid.

Signed-off-by: Florian Westphal <fwestphal@astaro.com>
---
 net/bridge/netfilter/ebtables.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
index 12beb58..1939041 100644
--- a/net/bridge/netfilter/ebtables.c
+++ b/net/bridge/netfilter/ebtables.c
@@ -442,6 +442,8 @@ static int ebt_verify_pointers(struct ebt_replace *repl,
 				break;
 			if (left < e->next_offset)
 				break;
+			if (e->next_offset < sizeof(struct ebt_entry))
+				return -EINVAL;
 			offset += e->next_offset;
 		}
 	}
-- 
1.6.4.4


  reply	other threads:[~2010-02-05  1:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-05  1:43 [PATCH 0/7] netfilter: ebtables: CONFIG_COMPAT support Florian Westphal
2010-02-05  1:43 ` Florian Westphal [this message]
2010-02-05  1:43 ` [PATCH 2/7] netfilter: ebtables: avoid explicit XT_ALIGN() in match/targets Florian Westphal
2010-02-05  1:43 ` [PATCH 3/7] netfilter: CONFIG_COMPAT: allow delta to exceed 32767 Florian Westphal
2010-02-05  1:43 ` [PATCH 4/7] netfilter: ebtables: split do_replace into two functions Florian Westphal
2010-02-05  1:43 ` [PATCH 5/7] netfilter: ebtables: add CONFIG_COMPAT support Florian Westphal
2010-02-05 13:52   ` Florian Westphal
2010-02-07 22:43   ` Florian Westphal
2010-02-05  1:43 ` [PATCH 6/7] netfilter: ebt_limit: " Florian Westphal
2010-02-05  1:43 ` [PATCH 7/7] netfilter: ebtables: mark: " Florian Westphal
2010-02-05  7:15 ` [PATCH 0/7] netfilter: ebtables: " Jan Engelhardt
2010-02-05 14:00   ` Florian Westphal
2010-02-05 17:15     ` Bart De Schuymer
2010-02-05 18:02       ` David Miller
2010-02-06 13:08         ` Bart De Schuymer
2010-02-06 13:50           ` Jan Engelhardt
2010-02-07 22:38           ` Florian Westphal
2010-02-07 23:19             ` Bart De Schuymer
2010-02-07 23:28               ` Florian Westphal
2010-02-05 19:53       ` Florian Westphal
2010-02-05 20:07         ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1265334195-28120-2-git-send-email-fw@strlen.de \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).