From: Tim Gardner <tim.gardner@canonical.com>
To: kaber@trash.net
Cc: netfilter-devel@vger.kernel.org, Tim Gardner <tim.gardner@canonical.com>
Subject: [PATCH 2/3] netfilter: xt_connbytes: Force CT accounting to be enabled
Date: Thu, 24 Jun 2010 09:27:36 -0600 [thread overview]
Message-ID: <1277393257-15281-3-git-send-email-tim.gardner@canonical.com> (raw)
In-Reply-To: <1277393257-15281-1-git-send-email-tim.gardner@canonical.com>
Check at rule install time that CT accounting is enabled. Force it
to be enabled if not while also emitting a warning since this is not
the default state.
This is in preparation for deprecating CONFIG_NF_CT_ACCT.
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
net/netfilter/xt_connbytes.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/net/netfilter/xt_connbytes.c b/net/netfilter/xt_connbytes.c
index 7351783..b0cda8c 100644
--- a/net/netfilter/xt_connbytes.c
+++ b/net/netfilter/xt_connbytes.c
@@ -112,6 +112,16 @@ static int connbytes_mt_check(const struct xt_mtchk_param *par)
if (ret < 0)
pr_info("cannot load conntrack support for proto=%u\n",
par->family);
+
+ /*
+ * This filter cannot function correctly unless connection tracking
+ * accounting is enabled, so complain in the hope that someone notices.
+ */
+ if (nf_ct_acct_enabled(par) == false) {
+ pr_warning("Forcing CT accounting to be enabled\n");
+ nf_ct_set_acct(par, true);
+ }
+
return ret;
}
--
1.7.0.4
next prev parent reply other threads:[~2010-06-24 15:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 15:27 nf-next-2.6 pull request, Complete deprecation of CONFIG_NF_CT_ACCT (V3) Tim Gardner
2010-06-24 15:27 ` [PATCH 1/3] netfilter: Expose connection tracking accounting toggles Tim Gardner
2010-06-24 15:36 ` Patrick McHardy
2010-06-24 16:07 ` Tim Gardner
2010-06-24 17:14 ` Jan Engelhardt
2010-06-24 15:27 ` Tim Gardner [this message]
2010-06-24 17:15 ` [PATCH 2/3] netfilter: xt_connbytes: Force CT accounting to be enabled Jan Engelhardt
2010-06-24 18:49 ` Tim Gardner
2010-06-25 8:44 ` Patrick McHardy
2010-06-24 15:27 ` [PATCH 3/3] netfilter: Complete the deprecation of CONFIG_NF_CT_ACCT Tim Gardner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277393257-15281-3-git-send-email-tim.gardner@canonical.com \
--to=tim.gardner@canonical.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).