netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: luciano.coelho@nokia.com
To: netfilter-devel@vger.kernel.org
Cc: netdev@vger.kernel.org, kaber@trash.net, jengelh@medozas.de,
	sameo@linux.intel.com
Subject: [PATCH v2 0/2] netfilter: xtables: xt_condition inclusion and change to u32
Date: Fri,  6 Aug 2010 15:21:46 +0300	[thread overview]
Message-ID: <1281097308-1515-1-git-send-email-luciano.coelho@nokia.com> (raw)

From: Luciano Coelho <luciano.coelho@nokia.com>

Hello,

Here v2 of the xt_condition patch, it contains some changes suggested by Jan.

When these patches get accepted, I'll send the implementation of the condition
target, as discussed before.

In RFC v2 I've made a few changes as discussed in the review:

  * Removed per-netns module parameters
  * Use par->net instead of current->nsproxy->net_ns
  * Fix file-leak in procfs when exiting the netns

I didn't get any more comments in RFC v2, so I assume it is okay to send it for
inclusion.

>From [RFC v2] to [PATCH], I've only rebased and added a new patch to support
u32 instead of boolean as the value for the condition.

In PATCH v2:

  * Bumped up the revision to 2
  * Changed the buffer declaration to have the size of the biggest possible u32 string
  * Return -ERANGE instead of -EINVALID when the value passed is too big.

Cheers,
Luca.


Luciano Coelho (2):
  netfilter: xtables: inclusion of xt_condition
  netfilter: xt_condition: change the value from boolean to u32

 include/linux/netfilter/Kbuild         |    1 +
 include/linux/netfilter/xt_condition.h |   15 ++
 net/netfilter/Kconfig                  |    8 +
 net/netfilter/Makefile                 |    1 +
 net/netfilter/xt_condition.c           |  269 ++++++++++++++++++++++++++++++++
 5 files changed, 294 insertions(+), 0 deletions(-)
 create mode 100644 include/linux/netfilter/xt_condition.h
 create mode 100644 net/netfilter/xt_condition.c


             reply	other threads:[~2010-08-06 12:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-06 12:21 luciano.coelho [this message]
2010-08-06 12:21 ` [PATCH v2 1/2] netfilter: xtables: inclusion of xt_condition luciano.coelho
2010-08-06 12:21 ` [PATCH v2 2/2] netfilter: xt_condition: change the value from boolean to u32 luciano.coelho
2010-08-06 13:54 ` [PATCH v2 0/2] netfilter: xtables: xt_condition inclusion and change " Patrick McHardy
2010-08-06 14:06   ` Luciano Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1281097308-1515-1-git-send-email-luciano.coelho@nokia.com \
    --to=luciano.coelho@nokia.com \
    --cc=jengelh@medozas.de \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).