netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* HFSC warning issue
@ 2011-07-11  9:26 François Delawarde
  2011-07-11 11:56 ` Michal Soltys
  0 siblings, 1 reply; 5+ messages in thread
From: François Delawarde @ 2011-07-11  9:26 UTC (permalink / raw)
  To: netfilter-devel

Hi all,

I'm having the same HFSC issues as described here:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=631945

Some user reports that he made it work by reverting this patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;f=net/sched/sch_hfsc.c;h=47496098d35c2876cd0b5a88e1365922cc369ce9;hp=abd904be428717462395d62adb682023e64e17a5;hb=3b2eb6131e2f6ff646abb0fc69648179b8b70216;hpb=9c01ae58d4fee39e2af5b1379ee5431dd585cf62


Is this the correct solution? Any "clean" patch I could test that would
resolve this issue?

Thanks,
François.

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: HFSC warning issue
  2011-07-11  9:26 François Delawarde
@ 2011-07-11 11:56 ` Michal Soltys
  2011-07-11 12:11   ` Michal Soltys
  0 siblings, 1 reply; 5+ messages in thread
From: Michal Soltys @ 2011-07-11 11:56 UTC (permalink / raw)
  To: fdelawarde; +Cc: netfilter-devel, 631945, kaber

W dniu 11.07.2011 11:26, François Delawarde pisze:
> Hi all,
> 
> I'm having the same HFSC issues as described here:
> 
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=631945
> 
> Some user reports that he made it work by reverting this patch:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;f=net/sched/sch_hfsc.c;h=47496098d35c2876cd0b5a88e1365922cc369ce9;hp=abd904be428717462395d62adb682023e64e17a5;hb=3b2eb6131e2f6ff646abb0fc69648179b8b70216;hpb=9c01ae58d4fee39e2af5b1379ee5431dd585cf62
> 
> 
> Is this the correct solution? Any "clean" patch I could test that would
> resolve this issue?
> 
> Thanks,
> François.
> 

Hmmm,

This commit in mention is the patch I submitted 
a while ago, namely:

http://kerneltrap.org/mailarchive/linux-netdev/2010/8/30/6284141

Whole rationale and short discussion regarding the 
change is in that thread. 

In a nutshell - it fixed certain scenario which could cause 
bursty traffic, but the change is just a minor adjustment. Let 
me sit a bit on this thing, and why it manages to trigger that 
warning ...

For a quick fix - reverting that commit should be perfectly 
safe - there were no other patches related to this one.

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: HFSC warning issue
  2011-07-11 11:56 ` Michal Soltys
@ 2011-07-11 12:11   ` Michal Soltys
  2011-07-11 14:11     ` François Delawarde
  0 siblings, 1 reply; 5+ messages in thread
From: Michal Soltys @ 2011-07-11 12:11 UTC (permalink / raw)
  To: fdelawarde; +Cc: netfilter-devel, 631945, kaber

Missed explanation behind the change:

http://www.spinics.net/lists/netdev/msg139383.html



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: HFSC warning issue
  2011-07-11 12:11   ` Michal Soltys
@ 2011-07-11 14:11     ` François Delawarde
  0 siblings, 0 replies; 5+ messages in thread
From: François Delawarde @ 2011-07-11 14:11 UTC (permalink / raw)
  To: Michal Soltys; +Cc: netfilter-devel, 631945, kaber

Not sure if its relevant but it seems that the ones that reported the
issue either use IFB or IMQ devices.

In my case, I use IMQ.

François.

On Mon, 2011-07-11 at 14:11 +0200, Michal Soltys wrote: 
> Missed explanation behind the change:
> 
> http://www.spinics.net/lists/netdev/msg139383.html
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: HFSC warning issue
@ 2011-07-13  9:21 Michal Pokrywka
  0 siblings, 0 replies; 5+ messages in thread
From: Michal Pokrywka @ 2011-07-13  9:21 UTC (permalink / raw)
  To: soltys; +Cc: netfilter-devel, 631945

Through serveral days my friend has done some tests with kernels 2.6.39.x

2.6.39.1, 2.6.39.2 and 2.6.39.3 are still affected.

2.6.39 (debian version 2.6.39-1 from http://snapshot.debian.org/binary/?cat=l)
works for several hours without triggering the bug. If it persist for some hours
more we will bisect 2.6.39 and 2.6.39.1 and try to find the related patch.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-07-13  9:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-13  9:21 HFSC warning issue Michal Pokrywka
  -- strict thread matches above, loose matches on Subject: below --
2011-07-11  9:26 François Delawarde
2011-07-11 11:56 ` Michal Soltys
2011-07-11 12:11   ` Michal Soltys
2011-07-11 14:11     ` François Delawarde

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).