netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Engelhardt <jengelh@medozas.de>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org
Subject: [PATCH 6/7] build: no need for error message in PKG_CHECK_MODULES
Date: Thu,  9 Sep 2010 01:32:41 +0200	[thread overview]
Message-ID: <1283988763-1577-7-git-send-email-jengelh@medozas.de> (raw)
In-Reply-To: <1283988763-1577-1-git-send-email-jengelh@medozas.de>

PKG_CHECK_MODULES already produces its own (and more verbose) messsage
when a module cannot be found.

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
 configure.ac |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index fe5b6fa..d5b65af 100644
--- a/configure.ac
+++ b/configure.ac
@@ -19,8 +19,6 @@ case "$host" in
 esac
 
 dnl Dependencies
-LIBNFNETLINK_REQUIRED=1.0.0
-
 AC_CHECK_PROG(HAVE_PKG_CONFIG, pkg-config, yes)
 if test "x$HAVE_PKG_CONFIG" = "x"
 then
@@ -29,8 +27,7 @@ then
 	exit 1
 fi
 
-PKG_CHECK_MODULES(LIBNFNETLINK, libnfnetlink >= $LIBNFNETLINK_REQUIRED,,
-	AC_MSG_ERROR(Cannot find libnfnetlink >= $LIBNFNETLINK_REQUIRED))
+PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.0])
 
 AC_CHECK_HEADERS(arpa/inet.h)
 dnl Check for inet_ntop
-- 
1.7.1


  parent reply	other threads:[~2010-09-08 23:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-08 23:32 libnetfilter_conntrack autotools updates Jan Engelhardt
2010-09-08 23:32 ` [PATCH 1/7] build: use autoconf-suggested naming of files Jan Engelhardt
2010-09-08 23:32 ` [PATCH 2/7] build: use modern call syntax for AC_INIT, AM_INIT_AUTOMAKE Jan Engelhardt
2010-09-08 23:32 ` [PATCH 3/7] build: avoid use of deprecated INCLUDES Jan Engelhardt
2010-09-08 23:32 ` [PATCH 4/7] build: use simpler autoreconf in autogen Jan Engelhardt
2010-09-08 23:32 ` [PATCH 5/7] build: run AC_CANONICAL_HOST only Jan Engelhardt
2010-09-08 23:32 ` Jan Engelhardt [this message]
2010-09-08 23:32 ` [PATCH 7/7] Add .gitignore Jan Engelhardt
2010-09-12  9:19 ` libnetfilter_conntrack autotools updates Pablo Neira Ayuso
  -- strict thread matches above, loose matches on Subject: below --
2010-10-30 22:08 libnetfilter_conntrack: build system cleanup Jan Engelhardt
2010-10-30 22:08 ` [PATCH 6/7] build: no need for error message in PKG_CHECK_MODULES Jan Engelhardt
2010-10-30 22:49 conntrack-tools: build system cleanups Jan Engelhardt
2010-10-30 22:49 ` [PATCH 6/7] build: no need for error message in PKG_CHECK_MODULES Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283988763-1577-7-git-send-email-jengelh@medozas.de \
    --to=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).