* [patch] arptables respect LDFLAGS @ 2010-09-15 13:48 Peter Volkov 2010-10-09 13:17 ` [patch] arptables: some patches from debian Peter Volkov 0 siblings, 1 reply; 5+ messages in thread From: Peter Volkov @ 2010-09-15 13:48 UTC (permalink / raw) To: ebtables-devel; +Cc: Netfilter Development Mailinglist [-- Attachment #1: Type: text/plain, Size: 99 bytes --] Hi. The patch in attachment makes arptables respect LDFLAGS. Please, apply. Thank you. -- Peter. [-- Attachment #2: arptables-0.0.3.4-ldflags.patch --] [-- Type: text/x-patch, Size: 372 bytes --] === modified file 'Makefile' --- Makefile 2010-09-15 11:51:49 +0000 +++ Makefile 2010-09-15 11:52:56 +0000 @@ -31,7 +31,7 @@ $(CC) $(CFLAGS) -c -o $@ $< arptables: arptables-standalone.o arptables.o libarptc/libarptc.o $(EXT_OBJS) - $(CC) $(CFLAGS) -o $@ $^ + $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $^ $(DESTDIR)$(MANDIR)/man8/arptables.8: arptables.8 mkdir -p $(@D) ^ permalink raw reply [flat|nested] 5+ messages in thread
* [patch] arptables: some patches from debian 2010-09-15 13:48 [patch] arptables respect LDFLAGS Peter Volkov @ 2010-10-09 13:17 ` Peter Volkov 2010-10-09 19:17 ` Bart De Schuymer 0 siblings, 1 reply; 5+ messages in thread From: Peter Volkov @ 2010-10-09 13:17 UTC (permalink / raw) To: ebtables-devel; +Cc: Netfilter Development Mailinglist [-- Attachment #1.1: Type: text/plain, Size: 644 bytes --] Hi again. What is the best way to contact arptables developers? My previous patch was left without attention, should I resend it? In attachment there are three fixes from debian: 1. arptables_save patch makes arp_tables don't resolve host names and don't convert '*' interface names to any. Remove '*' interface names. 2. manpage patch removes old version from man page 3. is a patch from Jeroen van Wolffelaar to make arptables --proto-type also accept hexadecimal inputs (ethernet protocol numbers are often specfied in hex, not decimal), using standard strtol() behaviour (hex iff starts with 0x). Please, apply. -- Peter. [-- Attachment #1.2: arptables-0.0.3.4-arptables_save.patch --] [-- Type: text/x-patch, Size: 917 bytes --] # Don't resolve host names and don't convert '*' interface names to any. # Remove '*' interface names. diff -urNad arptables-0.0.3.3~/arptables-save arptables-0.0.3.3/arptables-save --- arptables-0.0.3.3~/arptables-save 2009-08-19 14:17:17.000000000 +0200 +++ arptables-0.0.3.3/arptables-save 2009-08-19 14:19:58.000000000 +0200 @@ -35,6 +35,8 @@ # Due to arptables "issues" with displaying device names # we need to use -v and then do some processing $line =~ s/\s,\s.*//; + $line =~ s/-i\s\*//; + $line =~ s/-o\s\*//; $rules = $rules . "-A $chain $line\n"; } @@ -47,7 +49,7 @@ # ======================================================== unless (-x "$tool") { print "ERROR: Tool $tool isn't executable"; exit -1; }; -$table =`$tool -t filter -L -v`; +$table =`$tool -t filter -L -v -n`; unless ($? == 0) { print $table; exit -1 }; &process_table($table); [-- Attachment #1.3: arptables-0.0.3.4-manpage.patch --] [-- Type: text/x-patch, Size: 459 bytes --] diff -urNad arptables-0.0.3.3~/arptables.8 arptables-0.0.3.3/arptables.8 --- arptables-0.0.3.3~/arptables.8 2007-08-19 15:04:51.000000000 +0200 +++ arptables-0.0.3.3/arptables.8 2008-05-08 18:56:35.000000000 +0200 @@ -22,7 +22,7 @@ .\" .\" .SH NAME -arptables (v.0.0.3-3) \- ARP table administration +arptables \- ARP table administration .SH SYNOPSIS .BR "arptables " [ "-t table" ] " -" [ AD ] " chain rule-specification " [ options ] .br [-- Attachment #1.4: arptables-0.0.3.4-type.patch --] [-- Type: text/x-patch, Size: 952 bytes --] # Patch from Jeroen van Wolffelaar <jeroen@wolffelaar.nl> to make # arptables --proto-type also accept hexadecimal inputs (ethernet protocol # numbers are often specfied in hex, not decimal), using standard strtol() # behaviour (hex iff starts with 0x). diff -urNad arptables-0.0.3.3~/arptables.c arptables-0.0.3.3/arptables.c --- arptables-0.0.3.3~/arptables.c 2007-08-19 15:04:51.000000000 +0200 +++ arptables-0.0.3.3/arptables.c 2008-05-08 19:16:43.000000000 +0200 @@ -2039,7 +2039,7 @@ check_inverse(optarg, &invert, &optind, argc); set_option(&options, OPT_P_TYPE, &fw.arp.invflags, invert); - if (get16_and_mask(argv[optind - 1], &fw.arp.arpro, &fw.arp.arpro_mask, 10)) { + if (get16_and_mask(argv[optind - 1], &fw.arp.arpro, &fw.arp.arpro_mask, 0)) { if (strcasecmp(argv[optind-1], "ipv4")) exit_error(PARAMETER_PROBLEM, "Problem with specified protocol type"); fw.arp.arpro = htons(0x800); [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] arptables: some patches from debian 2010-10-09 13:17 ` [patch] arptables: some patches from debian Peter Volkov @ 2010-10-09 19:17 ` Bart De Schuymer 2010-10-14 15:37 ` Peter Volkov 0 siblings, 1 reply; 5+ messages in thread From: Bart De Schuymer @ 2010-10-09 19:17 UTC (permalink / raw) To: Peter Volkov; +Cc: ebtables-devel, Netfilter Development Mailinglist Hello Peter, Patch 2 and 3 are committed. For the '*' part of patch 1 I'd rather remove the -v usage in arptables-restore. This will require fixing the reason why -v is used in the first place. I wasn't aware this is due to a bug: the -i and -o interfaces aren't printed unless -v is specified. I'll look into this. cheers, Bart On 09-10-10 15:17, Peter Volkov wrote: > Hi again. What is the best way to contact arptables developers? My > previous patch was left without attention, should I resend it? In > attachment there are three fixes from debian: > > 1. arptables_save patch makes arp_tables don't resolve host names and > don't convert '*' interface names to any. Remove '*' interface names. > 2. manpage patch removes old version from man page > 3. is a patch from Jeroen van Wolffelaar to make arptables --proto-type > also accept hexadecimal inputs (ethernet protocol numbers are often > specfied in hex, not decimal), using standard strtol() behaviour (hex > iff starts with 0x). > > Please, apply. > -- Bart De Schuymer www.artinalgorithms.be ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] arptables: some patches from debian 2010-10-09 19:17 ` Bart De Schuymer @ 2010-10-14 15:37 ` Peter Volkov 2010-10-24 17:10 ` Bart De Schuymer 0 siblings, 1 reply; 5+ messages in thread From: Peter Volkov @ 2010-10-14 15:37 UTC (permalink / raw) To: Bart De Schuymer; +Cc: ebtables-devel, Netfilter Development Mailinglist [-- Attachment #1: Type: text/plain, Size: 1310 bytes --] Hi Bart. Thank you for review/applying patches. Could you also apply attached patch to fix not respecting LDFLAGS issue (very similar to one I've sent you long time ago for ebtables :) ) -- Peter. В Сбт, 09/10/2010 в 21:17 +0200, Bart De Schuymer пишет: > Hello Peter, > > Patch 2 and 3 are committed. > For the '*' part of patch 1 I'd rather remove the -v usage in > arptables-restore. This will require fixing the reason why -v is used in > the first place. I wasn't aware this is due to a bug: the -i and -o > interfaces aren't printed unless -v is specified. I'll look into this. > > cheers, > Bart > > On 09-10-10 15:17, Peter Volkov wrote: > > Hi again. What is the best way to contact arptables developers? My > > previous patch was left without attention, should I resend it? In > > attachment there are three fixes from debian: > > > > 1. arptables_save patch makes arp_tables don't resolve host names and > > don't convert '*' interface names to any. Remove '*' interface names. > > 2. manpage patch removes old version from man page > > 3. is a patch from Jeroen van Wolffelaar to make arptables --proto-type > > also accept hexadecimal inputs (ethernet protocol numbers are often > > specfied in hex, not decimal), using standard strtol() behaviour (hex > > iff starts with 0x). [-- Attachment #2: arptables-0.0.3.4-ldflags.patch --] [-- Type: text/x-patch, Size: 372 bytes --] === modified file 'Makefile' --- Makefile 2010-09-15 11:51:49 +0000 +++ Makefile 2010-09-15 11:52:56 +0000 @@ -31,7 +31,7 @@ $(CC) $(CFLAGS) -c -o $@ $< arptables: arptables-standalone.o arptables.o libarptc/libarptc.o $(EXT_OBJS) - $(CC) $(CFLAGS) -o $@ $^ + $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $^ $(DESTDIR)$(MANDIR)/man8/arptables.8: arptables.8 mkdir -p $(@D) ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] arptables: some patches from debian 2010-10-14 15:37 ` Peter Volkov @ 2010-10-24 17:10 ` Bart De Schuymer 0 siblings, 0 replies; 5+ messages in thread From: Bart De Schuymer @ 2010-10-24 17:10 UTC (permalink / raw) To: Peter Volkov; +Cc: ebtables-devel, Netfilter Development Mailinglist Applied. Thanks, Bart On 14-10-10 17:37, Peter Volkov wrote: > Hi Bart. Thank you for review/applying patches. Could you also apply > attached patch to fix not respecting LDFLAGS issue (very similar to one > I've sent you long time ago for ebtables :) ) > > -- > Peter. > > В Сбт, 09/10/2010 в 21:17 +0200, Bart De Schuymer пишет: >> Hello Peter, >> >> Patch 2 and 3 are committed. >> For the '*' part of patch 1 I'd rather remove the -v usage in >> arptables-restore. This will require fixing the reason why -v is used in >> the first place. I wasn't aware this is due to a bug: the -i and -o >> interfaces aren't printed unless -v is specified. I'll look into this. >> >> cheers, >> Bart >> >> On 09-10-10 15:17, Peter Volkov wrote: >>> Hi again. What is the best way to contact arptables developers? My >>> previous patch was left without attention, should I resend it? In >>> attachment there are three fixes from debian: >>> >>> 1. arptables_save patch makes arp_tables don't resolve host names and >>> don't convert '*' interface names to any. Remove '*' interface names. >>> 2. manpage patch removes old version from man page >>> 3. is a patch from Jeroen van Wolffelaar to make arptables --proto-type >>> also accept hexadecimal inputs (ethernet protocol numbers are often >>> specfied in hex, not decimal), using standard strtol() behaviour (hex >>> iff starts with 0x). -- Bart De Schuymer www.artinalgorithms.be -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-10-24 17:10 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-09-15 13:48 [patch] arptables respect LDFLAGS Peter Volkov 2010-10-09 13:17 ` [patch] arptables: some patches from debian Peter Volkov 2010-10-09 19:17 ` Bart De Schuymer 2010-10-14 15:37 ` Peter Volkov 2010-10-24 17:10 ` Bart De Schuymer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).