From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balazs Scheidler Subject: Re: [PATCH 5/9] tproxy: allow non-local binds of IPv6 sockets if IP_TRANSPARENT is enabled Date: Wed, 20 Oct 2010 16:07:33 +0200 Message-ID: <1287583653.29676.9.camel@bzorp.lan> References: <20101020112118.6260.31618.stgit@este.odu> <20101020112118.6260.93956.stgit@este.odu> <4CBEE45D.2080201@linux-ipv6.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: KOVACS Krisztian , netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Patrick McHardy , David Miller To: YOSHIFUJI Hideaki Return-path: In-Reply-To: <4CBEE45D.2080201@linux-ipv6.org> Sender: netdev-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org On Wed, 2010-10-20 at 21:45 +0900, YOSHIFUJI Hideaki wrote: > (2010/10/20 20:21), KOVACS Krisztian wrote: > > From: Balazs Scheidler > > > > Signed-off-by: Balazs Scheidler > > Signed-off-by: KOVACS Krisztian > > --- > > net/ipv6/af_inet6.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c > > index 6022098..9480572 100644 > > --- a/net/ipv6/af_inet6.c > > +++ b/net/ipv6/af_inet6.c > > @@ -343,7 +343,7 @@ int inet6_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) > > */ > > v4addr = LOOPBACK4_IPV6; > > if (!(addr_type& IPV6_ADDR_MULTICAST)) { > > - if (!ipv6_chk_addr(net,&addr->sin6_addr, > > + if (!inet->transparent&& !ipv6_chk_addr(net,&addr->sin6_addr, > > dev, 0)) { > > err = -EADDRNOTAVAIL; > > goto out_unlock; > > > > > > As I wrote before in other thread, this does not seem sufficient -- > well, it is sufficient to allow non-local bind, but before we're > allowing this, we need add checks of source address in sending side. Can you please elaborate or point us to the other thread? Is it some kind of address-type check that we miss? -- Bazsi