netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kaber@trash.net
To: davem@davemloft.net
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH 4/5] ipv4: netfilter: arp_tables: fix information leak to userland
Date: Wed,  3 Nov 2010 23:12:51 +0100	[thread overview]
Message-ID: <1288822372-21245-5-git-send-email-kaber@trash.net> (raw)
In-Reply-To: <1288822372-21245-1-git-send-email-kaber@trash.net>

From: Vasiliy Kulikov <segooon@gmail.com>

Structure arpt_getinfo is copied to userland with the field "name"
that has the last elements unitialized.  It leads to leaking of
contents of kernel stack memory.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
 net/ipv4/netfilter/arp_tables.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c
index 3cad259..3fac340 100644
--- a/net/ipv4/netfilter/arp_tables.c
+++ b/net/ipv4/netfilter/arp_tables.c
@@ -927,6 +927,7 @@ static int get_info(struct net *net, void __user *user,
 			private = &tmp;
 		}
 #endif
+		memset(&info, 0, sizeof(info));
 		info.valid_hooks = t->valid_hooks;
 		memcpy(info.hook_entry, private->hook_entry,
 		       sizeof(info.hook_entry));
-- 
1.7.1


  parent reply	other threads:[~2010-11-03 22:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-03 22:12 [PATCH 0/5] netfilter: netfilter fixes kaber
2010-11-03 22:12 ` [PATCH 1/5] netfilter: nf_conntrack: allow nf_ct_alloc_hashtable() to get highmem pages kaber
2010-11-03 22:12 ` [PATCH 2/5] netfilter: nf_nat: fix compiler warning with CONFIG_NF_CT_NETLINK=n kaber
2010-11-03 22:12 ` [PATCH 3/5] netfilter: fix nf_conntrack_l4proto_register() kaber
2010-11-03 22:12 ` kaber [this message]
2010-11-03 22:12 ` [PATCH 5/5] ipv4: netfilter: ip_tables: fix information leak to userland kaber
2010-11-03 22:55   ` Jan Engelhardt
2010-11-04  1:55     ` David Miller
2010-11-04  1:54 ` [PATCH 0/5] netfilter: netfilter fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288822372-21245-5-git-send-email-kaber@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).