From: Eric Paris <eparis@redhat.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
selinux@tycho.nsa.gov, netfilter-devel@vger.kernel.org,
equinox@diac24.net, eric.dumazet@gmail.com, davem@davemloft.net,
hzhong@gmail.com, jmorris@namei.org, kuznet@ms2.inr.ac.ru,
paul.moore@hp.com, pekkas@netcore.fi, sds@tycho.nsa.gov,
yoshfuji@linux-ipv6.org
Subject: Re: [PATCH 3/3] SELinux: return -ECONNREFUSED from ip_postroute to signal fatal error
Date: Wed, 17 Nov 2010 09:38:59 -0500 [thread overview]
Message-ID: <1290004739.14282.73.camel@localhost.localdomain> (raw)
In-Reply-To: <4CE3BFC4.1010706@trash.net>
On Wed, 2010-11-17 at 12:43 +0100, Patrick McHardy wrote:
> On 16.11.2010 22:52, Eric Paris wrote:
> > The SELinux netfilter hooks just return NF_DROP if they drop a packet. We
> > want to signal that a drop in this hook is a permanant fatal error and is not
> > transient. If we do this the error will be passed back up the stack in some
> > places and applications will get a faster interaction that something went
> > wrong.
>
> Looks good to me. I'd suggest to have these patches go through Dave's
> tree since I want to make use of the netfilter error propagation
> mechanism to return proper errno codes for netfilter re-routing
> failures.
I'd be happy if Dave pulled patches 1 and 2. I can resend patch #3 once
I can cajole another of the SELinux maintainers to look at it (I believe
he most likely one is on vacation this week)
-Eric
next prev parent reply other threads:[~2010-11-17 14:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 21:52 [PATCH 1/3] netfilter: allow hooks to pass error code back up the stack Eric Paris
2010-11-16 21:52 ` [PATCH 2/3] network: tcp_connect should return certain errors " Eric Paris
2010-11-17 18:56 ` David Miller
2010-11-16 21:52 ` [PATCH 3/3] SELinux: return -ECONNREFUSED from ip_postroute to signal fatal error Eric Paris
2010-11-17 11:43 ` Patrick McHardy
2010-11-17 14:38 ` Eric Paris [this message]
2010-11-17 18:55 ` David Miller
2010-11-17 18:56 ` David Miller
2010-11-19 15:11 ` Paul Moore
2010-11-17 18:55 ` [PATCH 1/3] netfilter: allow hooks to pass error code back up the stack David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290004739.14282.73.camel@localhost.localdomain \
--to=eparis@redhat.com \
--cc=davem@davemloft.net \
--cc=equinox@diac24.net \
--cc=eric.dumazet@gmail.com \
--cc=hzhong@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=pekkas@netcore.fi \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).