From: kaber@trash.net
To: davem@davemloft.net
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
Jan Engelhardt <jengelh@medozas.de>
Subject: [PATCH 3/7] netfilter: xtables: remove duplicate member
Date: Thu, 20 Jan 2011 21:22:42 +0100 [thread overview]
Message-ID: <1295554966-5263-4-git-send-email-kaber@trash.net> (raw)
In-Reply-To: <1295554966-5263-1-git-send-email-kaber@trash.net>
From: Jan Engelhardt <jengelh@medozas.de>
Accidentally missed removing the old out-of-union "inverse" member,
which caused the struct size to change which then gives size mismatch
warnings when using an old iptables.
It is interesting to see that gcc did not warn about this before.
(Filed http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47376 )
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
include/linux/netfilter/xt_connlimit.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/netfilter/xt_connlimit.h b/include/linux/netfilter/xt_connlimit.h
index 8884efc..ab1d3b5 100644
--- a/include/linux/netfilter/xt_connlimit.h
+++ b/include/linux/netfilter/xt_connlimit.h
@@ -18,7 +18,7 @@ struct xt_connlimit_info {
};
#endif
};
- unsigned int limit, inverse;
+ unsigned int limit;
union {
/* revision 0 */
unsigned int inverse;
--
1.7.3.4
next prev parent reply other threads:[~2011-01-20 20:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 20:22 [PATCH 0/7] netfilter: netfilter fixes for net-next kaber
2011-01-20 20:22 ` [PATCH 1/7] netfilter: xtables: connlimit revision 1 kaber
2011-01-20 20:22 ` [PATCH 2/7] netfilter: do not omit re-route check on NF_QUEUE verdict kaber
2011-01-20 20:22 ` kaber [this message]
2011-01-20 20:22 ` [PATCH 4/7] netfilter: nf_nat: place conntrack in source hash after SNAT is done kaber
2011-01-20 20:22 ` [PATCH 5/7] netfilter: xtables: add missing header inclusions for headers_check kaber
2011-01-20 20:22 ` [PATCH 6/7] netfilter: nf_conntrack: fix linker error with NF_CONNTRACK_TIMESTAMP=n kaber
2011-01-20 20:22 ` [PATCH 7/7] netfilter: add a missing include in nf_conntrack_reasm.c kaber
2011-01-21 0:38 ` [PATCH 0/7] netfilter: netfilter fixes for net-next David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295554966-5263-4-git-send-email-kaber@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=jengelh@medozas.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).