From: Jan Engelhardt <jengelh@medozas.de>
To: kaber@trash.net
Cc: netfilter-devel@vger.kernel.org
Subject: [PATCH 6/7] iptables: remove bogus address-of
Date: Mon, 31 Jan 2011 03:12:51 +0100 [thread overview]
Message-ID: <1296439973-16089-7-git-send-email-jengelh@medozas.de> (raw)
In-Reply-To: <1296439973-16089-1-git-send-email-jengelh@medozas.de>
Casts are bad. &curtable is actually of type char (*)[], which is
quite different from what add_argv expects.
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
ip6tables-restore.c | 2 +-
iptables-restore.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ip6tables-restore.c b/ip6tables-restore.c
index 9948cd6..d8a45da 100644
--- a/ip6tables-restore.c
+++ b/ip6tables-restore.c
@@ -365,7 +365,7 @@ int main(int argc, char *argv[])
add_argv(argv[0]);
add_argv("-t");
- add_argv((char *) &curtable);
+ add_argv(curtable);
if (counters && pcnt && bcnt) {
add_argv("--set-counters");
diff --git a/iptables-restore.c b/iptables-restore.c
index 519d480..cd23cfa 100644
--- a/iptables-restore.c
+++ b/iptables-restore.c
@@ -370,7 +370,7 @@ main(int argc, char *argv[])
add_argv(argv[0]);
add_argv("-t");
- add_argv((char *) &curtable);
+ add_argv(curtable);
if (counters && pcnt && bcnt) {
add_argv("--set-counters");
--
1.7.1
next prev parent reply other threads:[~2011-01-31 2:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 2:12 iptables: misc fixes Jan Engelhardt
2011-01-31 2:12 ` [PATCH 1/7] libxt_quota: clarifications on matching Jan Engelhardt
2011-01-31 2:12 ` [PATCH 2/7] iptables: improve error reporting with extension loading troubles Jan Engelhardt
2011-01-31 2:12 ` [PATCH 3/7] libxt_u32: enclose argument in quotes Jan Engelhardt
2011-01-31 2:12 ` [PATCH 4/7] xtables: set custom opts to NULL on free Jan Engelhardt
2011-01-31 2:12 ` [PATCH 5/7] iptables: warn when parameter limit is exceeded Jan Engelhardt
2011-01-31 2:12 ` Jan Engelhardt [this message]
2011-01-31 2:12 ` [PATCH 7/7] iptables: remove more redundant casts Jan Engelhardt
2011-01-31 2:16 ` [PATCH 8/8] iptables: do not print trailing whitespaces Jan Engelhardt
2011-01-31 16:12 ` iptables: misc fixes Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296439973-16089-7-git-send-email-jengelh@medozas.de \
--to=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).