From: Jan Engelhardt <jengelh@medozas.de>
To: kaber@trash.net
Cc: netfilter-devel@vger.kernel.org
Subject: [PATCH 8/8] libipt_ECN: set proper option flags
Date: Sat, 19 Feb 2011 20:04:18 +0100 [thread overview]
Message-ID: <1298142259-11213-9-git-send-email-jengelh@medozas.de> (raw)
In-Reply-To: <1298142259-11213-1-git-send-email-jengelh@medozas.de>
When specifying --ecn-tcp-remove, *flags will be set to 1, which leads
to the ECN bits being removed from the IPv4 header, but in fact not
the TCP header.
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
extensions/libipt_ECN.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/extensions/libipt_ECN.c b/extensions/libipt_ECN.c
index e1f29b6..2aa1a00 100644
--- a/extensions/libipt_ECN.c
+++ b/extensions/libipt_ECN.c
@@ -53,7 +53,7 @@ static int ECN_parse(int c, char **argv, int invert, unsigned int *flags,
einfo->operation = IPT_ECN_OP_SET_ECE | IPT_ECN_OP_SET_CWR;
einfo->proto.tcp.ece = 0;
einfo->proto.tcp.cwr = 0;
- *flags = 1;
+ *flags |= IPT_ECN_OP_SET_ECE | IPT_ECN_OP_SET_CWR;
break;
case 'G':
if (*flags & IPT_ECN_OP_SET_CWR)
--
1.7.1
next prev parent reply other threads:[~2011-02-19 19:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-19 19:04 iptables: misc option edits Jan Engelhardt
2011-02-19 19:04 ` [PATCH 1/8] doc: fix wrong sentence about negation in xt_limit Jan Engelhardt
2011-02-19 19:04 ` [PATCH 2/8] doc: fix misspelling of "field" Jan Engelhardt
2011-02-19 19:04 ` [PATCH 3/8] extensions: remove redundant init functions Jan Engelhardt
2011-02-19 19:04 ` [PATCH 4/8] Remove unused CVS expanded keywords Jan Engelhardt
2011-02-19 19:04 ` [PATCH 5/8] libip6t_dst: remove unimplemented --dst-not-strict Jan Engelhardt
2011-02-19 19:04 ` [PATCH 6/8] libip6t_hbh: remove unimplemented --hbh-not-strict Jan Engelhardt
2011-02-19 19:04 ` [PATCH 7/8] extensions: add missing checks for specific flags Jan Engelhardt
2011-02-19 19:04 ` Jan Engelhardt [this message]
2011-02-23 16:40 ` iptables: misc option edits Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298142259-11213-9-git-send-email-jengelh@medozas.de \
--to=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).