From: Simon Horman <horms@verge.net.au>
To: lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org
Cc: Patrick McHardy <kaber@trash.net>,
Hans Schillstrom <hans@schillstrom.com>,
Julian Anastasov <ja@ssi.bg>, Simon Horman <horms@verge.net.au>,
Jesper Juhl <jj@chaosbits.net>
Subject: [PATCH 4/4] Fix variable assignment in ip_vs_notrack
Date: Mon, 14 Mar 2011 07:44:21 +0900 [thread overview]
Message-ID: <1300056261-14709-5-git-send-email-horms@verge.net.au> (raw)
In-Reply-To: <1300056261-14709-1-git-send-email-horms@verge.net.au>
From: Jesper Juhl <jj@chaosbits.net>
There's no sense to 'ct = ct = ' in ip_vs_notrack(). Just assign
nf_ct_get()'s return value directly to the pointer variable 'ct' once.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
include/net/ip_vs.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h
index e74da41e..1dcb75d 100644
--- a/include/net/ip_vs.h
+++ b/include/net/ip_vs.h
@@ -1190,7 +1190,7 @@ static inline void ip_vs_notrack(struct sk_buff *skb)
{
#if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE)
enum ip_conntrack_info ctinfo;
- struct nf_conn *ct = ct = nf_ct_get(skb, &ctinfo);
+ struct nf_conn *ct = nf_ct_get(skb, &ctinfo);
if (!ct || !nf_ct_is_untracked(ct)) {
nf_reset(skb);
--
1.7.2.3
next prev parent reply other threads:[~2011-03-13 22:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-13 22:44 [GIT PULL nf-next-2.6] IPVS Simon Horman
2011-03-13 22:44 ` [PATCH 1/4] ipvs: avoid lookup for fwmark 0 Simon Horman
2011-03-13 22:44 ` [PATCH 2/4] ipvs: remove _bh from percpu stats reading Simon Horman
2011-03-13 22:44 ` [PATCH 3/4] netfilter:ipvs: use kmemdup Simon Horman
2011-03-13 22:44 ` Simon Horman [this message]
2011-03-14 18:17 ` [GIT PULL nf-next-2.6] IPVS Patrick McHardy
2011-03-14 23:13 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300056261-14709-5-git-send-email-horms@verge.net.au \
--to=horms@verge.net.au \
--cc=hans@schillstrom.com \
--cc=ja@ssi.bg \
--cc=jj@chaosbits.net \
--cc=kaber@trash.net \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).