From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Schillstrom Subject: [v2 PATCH 0/6] IPVS: init and cleanup. Date: Sun, 1 May 2011 18:50:12 +0200 Message-ID: <1304268618-18103-1-git-send-email-hans@schillstrom.com> Cc: hans.schillstrom@ericsson.com, Hans Schillstrom To: ja@ssi.bg, horms@verge.net.au, ebiederm@xmission.com, lvs-devel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org Return-path: Sender: lvs-devel-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org This patch series handles exit from a network name space. REVISION This is version 4 OVERVIEW Basically there was three faults in the netns implementation. - Kernel threads hold devices and preventing an exit. - dst cache holds references to devices. - Services was not always released. Patch 1 & 3 contains the functionality 4 renames funcctions 5 removes empty functions 6 Debuging. IMPLEMENTATION - Avoid to increment the usage counter for kernel threads. this is done in the first patch. - Patch 3 tries to restore the cleanup order. Add NETDEV_UNREGISTER notification for dst_reset (eleased version could not handle unregistration of netdevices.) Comments from Eric, Julian and Simon implmented. Revision 3 Residies in patch 3 Throttle renamed to enable. Comments from Julian implemented Check enable in ip_vs_in, ip_vs_out and ip_vs_forward_icmp* Remove in ip_vs_in_icmp*. ip_vs_svc_reset() moved into ip_vs_dst_event(). ip_vs_service_cleanup() uses ip_vs_flush and mutex lock. ip_vs_unlink_service_nolock() added. Revision 4 ip_vs_unlink_service_nolock() removed. ip_vs_flush() reverted. Return code check changed in stop thread. An netns exit could look like this: IPVS: Enter: __ip_vs_dev_cleanup, net/netfilter/ipvs/ip_vs_core.c line 1966 IPVS: stopping master sync thread 1845 ... IPVS: stopping backup sync thread 1850 ... IPVS: Leave: __ip_vs_dev_cleanup, net/netfilter/ipvs/ip_vs_core.c line 1969 IPVS: ip_vs_dst_event() dev=ip6tnl0 IPVS: Enter: ip_vs_dst_event, net/netfilter/ipvs/ip_vs_ctl.c line 1540 IPVS: Leave: ip_vs_dst_event, net/netfilter/ipvs/ip_vs_ctl.c line 1567 IPVS: ip_vs_dst_event() dev=sit0 IPVS: Enter: ip_vs_dst_event, net/netfilter/ipvs/ip_vs_ctl.c line 1540 IPVS: Leave: ip_vs_dst_event, net/netfilter/ipvs/ip_vs_ctl.c line 1567 IPVS: ip_vs_dst_event() dev=tunl0 IPVS: Enter: ip_vs_dst_event, net/netfilter/ipvs/ip_vs_ctl.c line 1540 IPVS: Leave: ip_vs_dst_event, net/netfilter/ipvs/ip_vs_ctl.c line 1567 IPVS: ip_vs_dst_event() dev=eth1 IPVS: Enter: ip_vs_dst_event, net/netfilter/ipvs/ip_vs_ctl.c line 1540 IPVS: Leave: ip_vs_dst_event, net/netfilter/ipvs/ip_vs_ctl.c line 1567 IPVS: ip_vs_dst_event() dev=eth0 IPVS: Enter: ip_vs_dst_event, net/netfilter/ipvs/ip_vs_ctl.c line 1540 IPVS: Reset dev:eth0 dest 192.168.1.6:0 ,dest->refcnt=2380471 IPVS: Reset dev:eth0 dest 192.168.1.4:0 ,dest->refcnt=2380471 IPVS: Reset dev:eth0 dest 192.168.1.3:0 ,dest->refcnt=2380471 IPVS: Leave: ip_vs_dst_event, net/netfilter/ipvs/ip_vs_ctl.c line 1567 IPVS: ip_vs_dst_event() dev=lo IPVS: Enter: ip_vs_dst_event, net/netfilter/ipvs/ip_vs_ctl.c line 1540 IPVS: Leave: ip_vs_dst_event, net/netfilter/ipvs/ip_vs_ctl.c line 1567 IPVS: Enter: ip_vs_service_net_cleanup, net/netfilter/ipvs/ip_vs_ctl.c line 1498 IPVS: __ip_vs_del_service: enter IPVS: Removing destination 0/[2003:0000:0000:0000:0000:0002:0000:0006]:80 IPVS: Removing destination 0/[2003:0000:0000:0000:0000:0002:0000:0004]:80 IPVS: Removing destination 0/[2003:0000:0000:0000:0000:0002:0000:0003]:80 IPVS: Removing service 0/[2003:0000:0000:0000:0000:0002:0001:0100]:80 usecnt=0 IPVS: __ip_vs_del_service: enter IPVS: Moving dest 192.168.1.6:0 into trash, dest->refcnt=2380470 IPVS: Moving dest 192.168.1.4:0 into trash, dest->refcnt=2380470 IPVS: Moving dest 192.168.1.3:0 into trash, dest->refcnt=2380470 IPVS: Leave: ip_vs_service_net_cleanup, net/netfilter/ipvs/ip_vs_ctl.c line 1503 IPVS: Enter: ip_vs_control_net_cleanup, net/netfilter/ipvs/ip_vs_ctl.c line 3734 IPVS: Removing service 80/0.0.0.0:0 usecnt=0 IPVS: Leave: ip_vs_control_net_cleanup, net/netfilter/ipvs/ip_vs_ctl.c line 3742 IPVS: ipvs netns 13 released PATCH SET This patch set is based upon net-next-2.6 (2.6.39-rc2) SUMMARY include/net/ip_vs.h | 23 ++++-- net/netfilter/ipvs/ip_vs_app.c | 23 +----- net/netfilter/ipvs/ip_vs_conn.c | 14 +--- net/netfilter/ipvs/ip_vs_core.c | 132 +++++++++++++++++++++++--------- net/netfilter/ipvs/ip_vs_ctl.c | 158 ++++++++++++++++++++++++++++++-------- net/netfilter/ipvs/ip_vs_est.c | 21 +----- net/netfilter/ipvs/ip_vs_proto.c | 11 +-- net/netfilter/ipvs/ip_vs_sync.c | 70 +++++++++--------- 8 files changed, 285 insertions(+), 167 deletions(-)