From: pablo@netfilter.org
To: netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, Eric Dumazet <eric.dumazet@gmail.com>,
Patrick McHardy <kaber@trash.net>
Subject: [PATCH 2/8] netfilter: fix ebtables compat support
Date: Tue, 10 May 2011 12:05:53 +0200 [thread overview]
Message-ID: <1305021959-2980-3-git-send-email-pablo@netfilter.org> (raw)
In-Reply-To: <1305021959-2980-1-git-send-email-pablo@netfilter.org>
From: Eric Dumazet <eric.dumazet@gmail.com>
commit 255d0dc34068a976 (netfilter: x_table: speedup compat operations)
made ebtables not working anymore.
1) xt_compat_calc_jump() is not an exact match lookup
2) compat_table_info() has a typo in xt_compat_init_offsets() call
3) compat_do_replace() misses a xt_compat_init_offsets() call
Reported-by: dann frazier <dannf@dannf.org>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
net/bridge/netfilter/ebtables.c | 3 ++-
net/netfilter/x_tables.c | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
index 893669c..9707079 100644
--- a/net/bridge/netfilter/ebtables.c
+++ b/net/bridge/netfilter/ebtables.c
@@ -1766,7 +1766,7 @@ static int compat_table_info(const struct ebt_table_info *info,
newinfo->entries_size = size;
- xt_compat_init_offsets(AF_INET, info->nentries);
+ xt_compat_init_offsets(NFPROTO_BRIDGE, info->nentries);
return EBT_ENTRY_ITERATE(entries, size, compat_calc_entry, info,
entries, newinfo);
}
@@ -2240,6 +2240,7 @@ static int compat_do_replace(struct net *net, void __user *user,
xt_compat_lock(NFPROTO_BRIDGE);
+ xt_compat_init_offsets(NFPROTO_BRIDGE, tmp.nentries);
ret = compat_copy_entries(entries_tmp, tmp.entries_size, &state);
if (ret < 0)
goto out_unlock;
diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c
index a9adf4c..8a025a5 100644
--- a/net/netfilter/x_tables.c
+++ b/net/netfilter/x_tables.c
@@ -455,6 +455,7 @@ void xt_compat_flush_offsets(u_int8_t af)
vfree(xt[af].compat_tab);
xt[af].compat_tab = NULL;
xt[af].number = 0;
+ xt[af].cur = 0;
}
}
EXPORT_SYMBOL_GPL(xt_compat_flush_offsets);
@@ -473,8 +474,7 @@ int xt_compat_calc_jump(u_int8_t af, unsigned int offset)
else
return mid ? tmp[mid - 1].delta : 0;
}
- WARN_ON_ONCE(1);
- return 0;
+ return left ? tmp[left - 1].delta : 0;
}
EXPORT_SYMBOL_GPL(xt_compat_calc_jump);
--
1.7.2.3
next prev parent reply other threads:[~2011-05-10 10:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 10:05 [PATCH 0/8] netfilter: netfilter fixes for 2.6.39-rc7 pablo
2011-05-10 10:05 ` [PATCH 1/8] netfilter: ctnetlink: fix timestamp support for new conntracks pablo
2011-05-10 10:05 ` pablo [this message]
2011-05-15 16:34 ` [PATCH 2/8] netfilter: fix ebtables compat support Pablo Neira Ayuso
2011-05-10 10:05 ` [PATCH 3/8] netfilter: ebtables: only call xt_compat_add_offset once per rule pablo
2011-05-10 10:05 ` [PATCH 4/8] IPVS: Change of socket usage to enable name space exit pablo
2011-05-10 10:05 ` [PATCH 5/8] IPVS: init and cleanup restructuring pablo
2011-05-10 10:05 ` [PATCH 6/8] netfilter: IPv6: initialize TOS field in REJECT target module pablo
2011-05-11 5:12 ` Fernando Luis Vázquez Cao
2011-05-12 8:23 ` Pablo Neira Ayuso
2011-05-12 8:33 ` Fernando Luis Vázquez Cao
2011-05-10 10:05 ` [PATCH 7/8] netfilter: IPv6: fix DSCP mangle code pablo
2011-05-10 10:05 ` [PATCH 8/8] netfilter: revert a2361c8735e07322023aedc36e4938b35af31eb0 pablo
2011-05-10 10:14 ` Pablo Neira Ayuso
2011-05-10 19:01 ` [PATCH 0/8] netfilter: netfilter fixes for 2.6.39-rc7 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305021959-2980-3-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).