From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Engelhardt Subject: [PATCH 02/24] libipt_REDIRECT: "--to-ports" is not mandatory Date: Wed, 25 May 2011 01:08:03 +0200 Message-ID: <1306278506-11463-3-git-send-email-jengelh@medozas.de> References: <1306278506-11463-1-git-send-email-jengelh@medozas.de> Cc: netfilter-devel@vger.kernel.org To: kaber@trash.net Return-path: Received: from seven.medozas.de ([188.40.89.202]:40918 "EHLO seven.medozas.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932170Ab1EXXIa (ORCPT ); Tue, 24 May 2011 19:08:30 -0400 In-Reply-To: <1306278506-11463-1-git-send-email-jengelh@medozas.de> Sender: netfilter-devel-owner@vger.kernel.org List-ID: From: Lutz Jaenicke The REDIRECT target can be called without the --to-ports option being specified. From the manual page: ...without this, the destination port is never altered. Signed-off-by: Lutz Jaenicke Signed-off-by: Jan Engelhardt --- extensions/libipt_REDIRECT.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/extensions/libipt_REDIRECT.c b/extensions/libipt_REDIRECT.c index 426a746..e67360a 100644 --- a/extensions/libipt_REDIRECT.c +++ b/extensions/libipt_REDIRECT.c @@ -23,8 +23,7 @@ static void REDIRECT_help(void) } static const struct xt_option_entry REDIRECT_opts[] = { - {.name = "to-ports", .id = O_TO_PORTS, .type = XTTYPE_STRING, - .flags = XTOPT_MAND}, + {.name = "to-ports", .id = O_TO_PORTS, .type = XTTYPE_STRING}, {.name = "random", .id = O_RANDOM, .type = XTTYPE_NONE}, XTOPT_TABLEEND, }; -- 1.7.3.4