From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: Florian Westphal <fw@strlen.de>
Subject: [PATCH conntrack] conntrack: add missing break when parsing --id/--secmark options
Date: Wed, 15 Jun 2011 23:39:07 +0200 [thread overview]
Message-ID: <1308173947-3122-1-git-send-email-fw@strlen.de> (raw)
commit 147ed522f52a62ab0d854ddc443d27d97dbf6cdf
(conntrack: add support for mark mask) failed to add a break
after secmark/id option parsing.
Results in '-m 42 -c 1' to search for mark 1 instead of 42.
Signed-off-by: Florian Westphal <fw@strlen.de>
---
Sorry about this; i did not see it until now...
diff --git a/src/conntrack.c b/src/conntrack.c
index 3e1cb11..8eae554 100644
--- a/src/conntrack.c
+++ b/src/conntrack.c
@@ -1566,6 +1566,7 @@ int main(int argc, char *argv[])
nfct_set_attr_u32(tmpl.ct,
opt2attr[c],
strtoul(optarg, NULL, 0));
+ break;
case 'm':
options |= opt2type[c];
parse_u32_mask(optarg, &tmpl.mark);
--
1.7.3.4
next reply other threads:[~2011-06-15 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 21:39 Florian Westphal [this message]
2011-07-08 11:31 ` [PATCH conntrack] conntrack: add missing break when parsing --id/--secmark options Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308173947-3122-1-git-send-email-fw@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).