[PATCH] Correct CONNSECMARK_save()

[PATCH] Correct CONNSECMARK_save()

[Tom Eastep]

[-- Attachment #1.1: Type: text/plain, Size: 702 bytes --]

Output is missing a space between 'CONNSECMARK' and '--'.

        sami:~# iptables -N foo -t mangle
        sami:~# iptables -A foo -t mangle -j CONNSECMARK --save
        sami:~# iptables -S -t mangle
        -P PREROUTING ACCEPT
        -P INPUT ACCEPT
        -P FORWARD ACCEPT
        -P OUTPUT ACCEPT
        -P POSTROUTING ACCEPT
        -N foo
        -A foo -j CONNSECMARK--save
        sami:~# 

-Tom
-- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________


[-- Attachment #1.2: commit-953ba77 --]
[-- Type: text/plain, Size: 628 bytes --]

commit 953ba77affab19f16bd9064d6b8344c3d12a9b53
Author: Tom Eastep <teastep@shorewall.net>
Date:   Fri Sep 2 17:45:51 2011 -0700

    Resolve -S issue with CONNSECMARK

diff --git a/extensions/libxt_CONNSECMARK.c b/extensions/libxt_CONNSECMARK.c
index df2e6b8..0b3cd79 100644
--- a/extensions/libxt_CONNSECMARK.c
+++ b/extensions/libxt_CONNSECMARK.c
@@ -87,7 +87,7 @@ CONNSECMARK_save(const void *ip, const struct xt_entry_target *target)
 	const struct xt_connsecmark_target_info *info =
 		(struct xt_connsecmark_target_info*)target->data;
 
-	printf("--");
+	printf(" --");
 	print_connsecmark(info);
 }
 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] Correct CONNSECMARK_save()

[Jan Engelhardt]

On Saturday 2011-09-03 15:24, Tom Eastep wrote:

>Output is missing a space between 'CONNSECMARK' and '--'.
>
>        sami:~# iptables -N foo -t mangle
>        sami:~# iptables -A foo -t mangle -j CONNSECMARK --save
>        sami:~# iptables -S -t mangle
>        -P PREROUTING ACCEPT
>        -P INPUT ACCEPT
>        -P FORWARD ACCEPT
>        -P OUTPUT ACCEPT
>        -P POSTROUTING ACCEPT
>        -N foo
>        -A foo -j CONNSECMARK--save
>        sami:~# 

Taken.