From: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
To: netfilter-devel@vger.kernel.org
Cc: Patrick McHardy <kaber@trash.net>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Joe Perches <joe@perches.com>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Subject: [PATCH 3/6] netfilter: ipset: Remove unnecessary OOM logging messages
Date: Tue, 6 Sep 2011 21:59:04 +0200 [thread overview]
Message-ID: <1315339147-9617-4-git-send-email-kadlec@blackhole.kfki.hu> (raw)
In-Reply-To: <1315339147-9617-1-git-send-email-kadlec@blackhole.kfki.hu>
From: Joe Perches <joe@perches.com>
Removing unnecessary messages saves code and text.
Site specific OOM messages are duplications of a generic MM
out of memory message and aren't really useful, so just
delete them.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
---
net/netfilter/ipset/ip_set_core.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c
index 7fa4a89..d5c4b5b 100644
--- a/net/netfilter/ipset/ip_set_core.c
+++ b/net/netfilter/ipset/ip_set_core.c
@@ -1717,10 +1717,8 @@ ip_set_init(void)
ip_set_list = kzalloc(sizeof(struct ip_set *) * ip_set_max,
GFP_KERNEL);
- if (!ip_set_list) {
- pr_err("ip_set: Unable to create ip_set_list\n");
+ if (!ip_set_list)
return -ENOMEM;
- }
ret = nfnetlink_subsys_register(&ip_set_netlink_subsys);
if (ret != 0) {
--
1.7.0.4
next prev parent reply other threads:[~2011-09-06 19:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 19:59 [PATCH 0/6] ipset patches Jozsef Kadlecsik
2011-09-06 19:59 ` [PATCH 1/6] netfilter: ipset: Autoload set type modules safely Jozsef Kadlecsik
2011-09-07 14:41 ` Patrick McHardy
2011-09-06 19:59 ` [PATCH 2/6] netfilter: ipset: Dumping error could lead to kernel BUG Jozsef Kadlecsik
2011-09-07 14:42 ` Patrick McHardy
2011-09-06 19:59 ` Jozsef Kadlecsik [this message]
2011-09-07 14:42 ` [PATCH 3/6] netfilter: ipset: Remove unnecessary OOM logging messages Patrick McHardy
2011-09-06 19:59 ` [PATCH 4/6] netfilter: ipset: avoid use of kernel-only types Jozsef Kadlecsik
2011-09-07 14:44 ` Patrick McHardy
2011-09-06 19:59 ` [PATCH 5/6] netfilter: ipset: expose userspace-relevant parts in ip_set.h Jozsef Kadlecsik
2011-09-07 14:45 ` Patrick McHardy
2011-09-06 19:59 ` [PATCH 6/6] netfilter: ipset: use NFPROTO_ constants Jozsef Kadlecsik
2011-09-07 14:45 ` Patrick McHardy
2011-09-07 9:32 ` [PATCH 0/6] ipset patches Pablo Neira Ayuso
2011-09-07 12:04 ` Jozsef Kadlecsik
2011-09-07 14:39 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315339147-9617-4-git-send-email-kadlec@blackhole.kfki.hu \
--to=kadlec@blackhole.kfki.hu \
--cc=joe@perches.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).