From: Ben Hutchings <bhutchings@solarflare.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev <netdev@vger.kernel.org>,
Stephen Hemminger <shemminger@vyatta.com>,
netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: skb_checksum_help() vs GSO
Date: Thu, 12 Jan 2012 20:42:10 +0000 [thread overview]
Message-ID: <1326400930.2740.10.camel@bwh-desktop> (raw)
skb_checksum_help() does:
if (unlikely(skb_shinfo(skb)->gso_size)) {
/* Let GSO fix up the checksum. */
goto out_set_summed;
}
...
out_set_summed:
skb->ip_summed = CHECKSUM_NONE;
out:
return ret;
but skb_gso_segment() requires that skb->ip_summed == CHECKSUM_PARTIAL
and WARNs if not. I don't think there's any case where it's valid to
call both. Shouldn't skb_checksum_help() also WARN and return an error
code instead of muddling on?
Inspecting the callers of skb_checksum_help(), it looks like sch_netem's
'corrupt' option and xt_CHECKSUM might trigger this case.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next reply other threads:[~2012-01-12 20:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 20:42 Ben Hutchings [this message]
2012-01-12 22:03 ` skb_checksum_help() vs GSO Herbert Xu
2012-01-13 0:57 ` [RFC] netem: de-GSO packets before enqueing Stephen Hemminger
2012-01-13 15:54 ` Eric Dumazet
2012-01-13 19:20 ` Stephen Hemminger
2012-01-13 23:44 ` Eric Dumazet
2012-01-14 16:06 ` Hagen Paul Pfeifer
2012-01-12 22:10 ` skb_checksum_help() vs GSO Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326400930.2740.10.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).