From: Steven Rostedt <rostedt@goodmis.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Richard Weinberger <richard@nod.at>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, eric.dumazet@gmail.com,
jengelh@medozas.de, basti@b-bl.de
Subject: Re: [PATCH 1/2] Netfilter: xt_LOG: Implement ring buffer support
Date: Sun, 04 Mar 2012 14:57:37 -0500 [thread overview]
Message-ID: <1330891057.2679.18.camel@frodo> (raw)
In-Reply-To: <20120304190438.GA24722@1984>
On Sun, 2012-03-04 at 20:04 +0100, Pablo Neira Ayuso wrote:
> > diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
> > index b895d8b..ac62599 100644
> > --- a/net/netfilter/Kconfig
> > +++ b/net/netfilter/Kconfig
> > @@ -533,6 +533,19 @@ config NETFILTER_XT_TARGET_LOG
> >
> > To compile it as a module, choose M here. If unsure, say N.
> >
> > +if NETFILTER_XT_TARGET_LOG
> > +
> > +config NETFILTER_XT_TARGET_LOG_RING
> > + bool 'Ring buffer support'
> > + default y
> > + select RING_BUFFER
>
> Please, CC the ring buffer author, I'm not familar with that code and
> I'll be happy to have an acknowledgment from him stating that the ring
> buffer bits are OK.
I am Cc'd and I believe I did ack his first set of patches. I have to
admit, I haven't looked too deeply at them again. I can review the last
set and give another ack if you want.
-- Steve
next prev parent reply other threads:[~2012-03-04 19:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 23:27 [PATCH 1/2] Netfilter: xt_LOG: Implement ring buffer support Richard Weinberger
2012-02-15 23:28 ` [PATCH 2/2] Netfilter: xt_LOG: Add timestamp support Richard Weinberger
2012-03-04 19:04 ` [PATCH 1/2] Netfilter: xt_LOG: Implement ring buffer support Pablo Neira Ayuso
2012-03-04 19:57 ` Steven Rostedt [this message]
2012-03-04 21:16 ` Richard Weinberger
2012-03-05 18:58 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2012-02-15 13:55 Richard Weinberger
2012-02-14 23:36 Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330891057.2679.18.camel@frodo \
--to=rostedt@goodmis.org \
--cc=basti@b-bl.de \
--cc=eric.dumazet@gmail.com \
--cc=jengelh@medozas.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).