From: Miguel GAIO <miguel.gaio@efixo.com>
To: netfilter-devel@vger.kernel.org
Subject: libiptc: fix retry path in TC_INIT
Date: Tue, 17 Apr 2012 10:29:23 +0200 [thread overview]
Message-ID: <1334651363.10712.6.camel@mgo-thinkpad> (raw)
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
Hi,
There is an issue on TC_INIT retry path:
In error case, TC_FREE is called and close sockfd.
The retry does not reopen then always fail.
The proposing patch reopen sockfd in retry patch.
Miguel
[-- Attachment #2: libiptc-TC_INIT-fix-retry.patch --]
[-- Type: text/x-patch, Size: 730 bytes --]
>From 6dbb1a9f16c70a60c06559b31eac7ab3af789fa1 Mon Sep 17 00:00:00 2001
From: Miguel GAIO <miguel.gaio@efixo.com>
Date: Tue, 17 Apr 2012 10:16:28 +0200
Subject: [PATCH 2008/2008] libiptc: TC_INIT fix retry
---
libiptc/libiptc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libiptc/libiptc.c b/libiptc/libiptc.c
index 63965e7..cd2ad9d 100644
--- a/libiptc/libiptc.c
+++ b/libiptc/libiptc.c
@@ -1314,6 +1314,7 @@ TC_INIT(const char *tablename)
return NULL;
}
+retry:
sockfd = socket(TC_AF, SOCK_RAW, IPPROTO_RAW);
if (sockfd < 0)
return NULL;
@@ -1324,7 +1325,6 @@ TC_INIT(const char *tablename)
abort();
}
-retry:
s = sizeof(info);
strcpy(info.name, tablename);
--
1.7.9.5
next reply other threads:[~2012-04-17 8:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 8:29 Miguel GAIO [this message]
2012-04-18 23:12 ` libiptc: fix retry path in TC_INIT Pablo Neira Ayuso
2012-04-19 10:14 ` Miguel GAIO
2012-04-19 16:55 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334651363.10712.6.camel@mgo-thinkpad \
--to=miguel.gaio@efixo.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).