From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>, Julia Lawall <julia.lawall@lip6.fr>
Cc: coreteam@netfilter.org, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, netfilter@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 00/13] net: Add and use ether_addr_equal
Date: Wed, 09 May 2012 18:48:04 -0700 [thread overview]
Message-ID: <1336614484.1905.19.camel@joe2Laptop> (raw)
In-Reply-To: <20120509.212110.437114897180819434.davem@davemloft.net>
On Wed, 2012-05-09 at 21:21 -0400, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Tue, 8 May 2012 21:56:44 -0700
>
> > Add a boolean function to test 2 ethernet addresses for equality
> > Convert compare_ether_addr uses to ether_addr_equal
>
> This series looks great, I'll apply all of it.
coccinelle is a nifty, better sed, tool. Thanks Julia et al.
> That case you didn't convert in mac80211 is probably the
> bug Johannes was talking about which started this whole
> discussion.
Looks like it.
Do you want a similar patch/patches for drivers/net?
If I break it out by nominal driver/maintainer,
it'll be a highish number of low density patches.
$ git grep -w compare_ether_addr drivers/net | wc -l
59
$ git grep -w -l compare_ether_addr drivers/net | wc -l
31
Maybe just a single patch?
Also the compare_ether_addr_64bits function is
still used a couple dozen times. Maybe another
patch for those? ether_addr_equal_64bits?
next prev parent reply other threads:[~2012-05-10 1:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 4:56 [PATCH 00/13] net: Add and use ether_addr_equal Joe Perches
2012-05-09 4:56 ` [PATCH 04/13] bridge: netfilter: Convert compare_ether_addr to ether_addr_equal Joe Perches
2012-05-09 15:07 ` Stephen Hemminger
2012-05-09 4:56 ` [PATCH 10/13] " Joe Perches
2012-05-10 1:21 ` [PATCH 00/13] net: Add and use ether_addr_equal David Miller
2012-05-10 1:48 ` Joe Perches [this message]
2012-05-10 1:53 ` David Miller
2012-05-10 6:48 ` Johannes Berg
2012-05-10 6:54 ` Joe Perches
2012-05-10 6:56 ` Johannes Berg
2012-05-10 7:08 ` Emmanuel Grumbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336614484.1905.19.camel@joe2Laptop \
--to=joe@perches.com \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=julia.lawall@lip6.fr \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).