From: Joe Perches <joe@perches.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 00/13] net: Add and use ether_addr_equal
Date: Wed, 09 May 2012 23:54:20 -0700 [thread overview]
Message-ID: <1336632860.22495.6.camel@joe2Laptop> (raw)
In-Reply-To: <1336632528.4334.1.camel@jlt3.sipsolutions.net>
On Thu, 2012-05-10 at 08:48 +0200, Johannes Berg wrote:
> On Wed, 2012-05-09 at 21:21 -0400, David Miller wrote:
>
> > That case you didn't convert in mac80211 is probably the
> > bug Johannes was talking about which started this whole
> > discussion.
>
> The bug case that started it all is in net/wireless/scan.c and Emmanuel
> has since changed it back to memcmp(). Not sure if that's the one you
> were referring to or not :-)
That's the one that I left alone.
Post patch:
$ git grep -n -w compare_ether_addr net
net/batman-adv/main.h:198: * note: can't use compare_ether_addr() as it requires aligned memory
net/wireless/scan.c:381: return compare_ether_addr(a->bssid, b->bssid);
next prev parent reply other threads:[~2012-05-10 6:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 4:56 [PATCH 00/13] net: Add and use ether_addr_equal Joe Perches
2012-05-09 4:56 ` [PATCH 04/13] bridge: netfilter: Convert compare_ether_addr to ether_addr_equal Joe Perches
2012-05-09 15:07 ` Stephen Hemminger
2012-05-09 4:56 ` [PATCH 10/13] " Joe Perches
2012-05-10 1:21 ` [PATCH 00/13] net: Add and use ether_addr_equal David Miller
2012-05-10 1:48 ` Joe Perches
2012-05-10 1:53 ` David Miller
2012-05-10 6:48 ` Johannes Berg
2012-05-10 6:54 ` Joe Perches [this message]
2012-05-10 6:56 ` Johannes Berg
2012-05-10 7:08 ` Emmanuel Grumbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336632860.22495.6.camel@joe2Laptop \
--to=joe@perches.com \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).