From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: netfilter-devel@vger.kernel.org
Cc: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Subject: [PATCH 1/3] nfnetlink: Check callbacks before using those in nfnetlink_rcv_msg
Date: Thu, 28 Jun 2012 15:57:47 +0300 [thread overview]
Message-ID: <1340888269-4926-2-git-send-email-tomasz.bursztyka@linux.intel.com> (raw)
In-Reply-To: <1340888269-4926-1-git-send-email-tomasz.bursztyka@linux.intel.com>
nfnetlink_rcv_msg() might call a NULL callback which will cause NULL pointer
dereference.
Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
---
net/netfilter/nfnetlink.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c
index 3e797d1..4acdd76 100644
--- a/net/netfilter/nfnetlink.c
+++ b/net/netfilter/nfnetlink.c
@@ -184,9 +184,11 @@ replay:
lockdep_is_held(&nfnl_mutex)) != ss ||
nfnetlink_find_client(type, ss) != nc)
err = -EAGAIN;
- else
+ else if (nc->call)
err = nc->call(net->nfnl, skb, nlh,
(const struct nlattr **)cda);
+ else
+ err = -EINVAL;
nfnl_unlock();
}
if (err == -EAGAIN)
--
1.7.8.6
next prev parent reply other threads:[~2012-06-28 12:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 12:57 [PATCH 0/3] Nfnetlink and ipset fixes Tomasz Bursztyka
2012-06-28 12:57 ` Tomasz Bursztyka [this message]
2012-06-29 11:15 ` [PATCH 1/3] nfnetlink: Check callbacks before using those in nfnetlink_rcv_msg Pablo Neira Ayuso
2012-06-29 19:03 ` Jan Engelhardt
2012-06-30 8:54 ` Florian Westphal
2012-07-04 20:54 ` Pablo Neira Ayuso
2012-06-28 12:57 ` [PATCH 2/3] ipset: Handle properly an IPSET_CMD_NONE Tomasz Bursztyka
2012-06-28 14:40 ` Jozsef Kadlecsik
2012-06-29 11:13 ` Pablo Neira Ayuso
2012-06-28 12:57 ` [PATCH 3/3] nfnetlink: Unlock a previously locked rcu_read in nfnetlink_rcv_msg Tomasz Bursztyka
2012-06-28 13:30 ` Eric Dumazet
2012-06-29 11:13 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340888269-4926-2-git-send-email-tomasz.bursztyka@linux.intel.com \
--to=tomasz.bursztyka@linux.intel.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).