libnetfilter_queue build fix

libnetfilter_queue build fix

[Jan Engelhardt]

This was a fun one... I knew it pays off to build the openSUSE distro
packages with `./configure --includedir=SomethingNonStandard`
throughout! :)


The following changes since commit 7bd9edfe7849d8d1bc35f9ac28e949409da0bf10:

  build: remove unused lines in Makefile.am (2012-06-24 14:58:28 +0200)

are available in the git repository at:
  git://git.inai.de/libnetfilter_queue master

Jan Engelhardt (1):
      build: remove stray empty variable

 Make_global.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH] build: remove stray empty variable

[Jan Engelhardt]

Compilation can fail when libnfnetlink is not in a directory searched
by default. Reason is the empty KERNELDIR variable which makes for a
gcc command like:

	gcc -I. -I../include -I -Wall -I/usr/include/libnfnetlink-1.0.0+git28
	-Wall -c libnetfilter_queue.c

What one would expect is that gcc would search in the (non-existent)
directory "-Wall" and just continue as usual, since -Wall is specified
again. Instead, gcc versions before 4.6 attempt to search the
(similarly non-existent) directory "-I/usr/[...]" and thus miss.

Signed-off-by: Jan Engelhardt <jengelh@inai.de>
---
 Make_global.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Make_global.am b/Make_global.am
index c16cb09..a4e9bd9 100644
--- a/Make_global.am
+++ b/Make_global.am
@@ -1,2 +1,2 @@
-AM_CPPFLAGS = -I${top_srcdir}/include -I${KERNELDIR} ${LIBNFNETLINK_CFLAGS}
+AM_CPPFLAGS = -I${top_srcdir}/include ${LIBNFNETLINK_CFLAGS}
 AM_CFLAGS = -Wall
-- 
1.7.7

Re: libnetfilter_queue build fix

[Pablo Neira Ayuso]

On Sat, Jun 30, 2012 at 03:07:53AM +0200, Jan Engelhardt wrote:
> 
> This was a fun one... I knew it pays off to build the openSUSE distro
> packages with `./configure --includedir=SomethingNonStandard`
> throughout! :)

this seems to be a pretty old left-over in libnetfilter_queue. I'm
surprised nobody noticed so far.

> The following changes since commit 7bd9edfe7849d8d1bc35f9ac28e949409da0bf10:
> 
>   build: remove unused lines in Makefile.am (2012-06-24 14:58:28 +0200)
> 
> are available in the git repository at:
>   git://git.inai.de/libnetfilter_queue master

pulled, thanks.