netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Engelhardt <jengelh@inai.de>
To: kadlec@blackhole.kfki.hu
Cc: netfilter-devel@vger.kernel.org
Subject: [PATCH] build: restore -version-info
Date: Sat, 30 Jun 2012 20:47:23 +0200	[thread overview]
Message-ID: <1341082043-26584-2-git-send-email-jengelh@inai.de> (raw)
In-Reply-To: <1341082043-26584-1-git-send-email-jengelh@inai.de>

There was no noticable reason to switch to -version-number;
version-number would have also seen the use of 3:0:0, not 3:0:1.

3:0:1 only makes sense with -version-info, so put "-version-info"
back. However, since ipset-6.13 already released libipset.so.3, going
back to .so.2 might not be such a good idea, so continue using .so.3
by means of 3:0:0.

Also note that the version names in libipset.map generally are not
supposed to follow SO versions, but the program version):
IPSET_6.13 {...}.
---
 Make_global.am  |    2 +-
 lib/Makefile.am |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Make_global.am b/Make_global.am
index 4a8f61a..446c4de 100644
--- a/Make_global.am
+++ b/Make_global.am
@@ -69,7 +69,7 @@
 # interface. 
 
 #            curr:rev:age
-LIBVERSION = 3:0:1
+LIBVERSION = 3:0:0
 
 AM_CPPFLAGS = $(kinclude_CFLAGS) $(all_includes) -I$(top_srcdir)/include \
 	-I/usr/local/include
diff --git a/lib/Makefile.am b/lib/Makefile.am
index 392b5f9..fd853dd 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -19,7 +19,7 @@ lib_LTLIBRARIES = libipset.la
 
 include $(top_srcdir)/lib/Make_extra.am
 
-libipset_la_LDFLAGS = -Wl,--version-script=$(top_srcdir)/lib/libipset.map -version-number $(LIBVERSION)
+libipset_la_LDFLAGS = -Wl,--version-script=$(top_srcdir)/lib/libipset.map -version-info $(LIBVERSION)
 libipset_la_LIBADD  = ${libmnl_LIBS} $(IPSET_SETTYPE_STATIC_OBJECTS)
 libipset_la_SOURCES = \
 	data.c \
-- 
1.7.7


  reply	other threads:[~2012-06-30 18:47 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-29 20:04 [ANNOUNCE] ipset 6.13 released Jozsef Kadlecsik
2012-06-30 18:47 ` Jan Engelhardt
2012-06-30 18:47   ` Jan Engelhardt [this message]
2012-06-30 22:05     ` [PATCH] build: restore -version-info Jozsef Kadlecsik
2012-06-30 22:15       ` Jan Engelhardt
2012-06-30 22:31         ` Jozsef Kadlecsik
2012-06-30 22:50           ` Jan Engelhardt
2012-07-01 12:11             ` Jozsef Kadlecsik
2012-07-01 16:03               ` Jan Engelhardt
2012-07-01 17:20                 ` Jozsef Kadlecsik
2012-07-01 18:36                   ` Jan Engelhardt
2012-07-01 20:45                     ` Jozsef Kadlecsik
2012-07-01 10:46 ` [ANNOUNCE] ipset 6.13 released Mr Dash Four
2012-07-01 12:09   ` Jozsef Kadlecsik
2012-07-01 12:19     ` Mr Dash Four
2012-07-01 12:37       ` Jozsef Kadlecsik
2012-07-01 12:44         ` Mr Dash Four
2012-07-01 12:52           ` Jozsef Kadlecsik
2012-07-01 13:17             ` Mr Dash Four
2012-07-01 15:21               ` Jozsef Kadlecsik
2012-07-01 16:52                 ` Mr Dash Four
2012-07-01 21:30                 ` Neal Murphy
2012-07-01 21:55                   ` Jan Engelhardt
2012-07-01 22:59                     ` Neal Murphy
2012-07-01 22:58                 ` Amos Jeffries
2012-07-02  7:54                   ` Jozsef Kadlecsik
2012-07-02 13:11                     ` Mr Dash Four
2012-07-02 13:26                       ` Jozsef Kadlecsik
2012-07-02 14:28                         ` Mr Dash Four
2012-07-02 20:26                           ` Jozsef Kadlecsik
2012-07-10 16:27                     ` Alex Bligh
2012-07-01 18:32   ` Steven Kath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341082043-26584-2-git-send-email-jengelh@inai.de \
    --to=jengelh@inai.de \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).