netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: pablo@netfilter.org
To: netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: [PATCH 09/10] netfilter: replace list_for_each_continue_rcu with new interface
Date: Thu, 23 Aug 2012 01:38:45 +0200	[thread overview]
Message-ID: <1345678726-3109-10-git-send-email-pablo@netfilter.org> (raw)
In-Reply-To: <1345678726-3109-1-git-send-email-pablo@netfilter.org>

From: Michael Wang <wangyun@linux.vnet.ibm.com>

This patch replaces list_for_each_continue_rcu() with
list_for_each_entry_continue_rcu() to allow removing
list_for_each_continue_rcu().

Signed-off-by: Michael Wang <wangyun@linux.vnet.ibm.com>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 net/netfilter/core.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/net/netfilter/core.c b/net/netfilter/core.c
index 0bc6b60..8f4b0b2 100644
--- a/net/netfilter/core.c
+++ b/net/netfilter/core.c
@@ -131,14 +131,13 @@ unsigned int nf_iterate(struct list_head *head,
 			int hook_thresh)
 {
 	unsigned int verdict;
+	struct nf_hook_ops *elem = list_entry_rcu(*i, struct nf_hook_ops, list);
 
 	/*
 	 * The caller must not block between calls to this
 	 * function because of risk of continuing from deleted element.
 	 */
-	list_for_each_continue_rcu(*i, head) {
-		struct nf_hook_ops *elem = (struct nf_hook_ops *)*i;
-
+	list_for_each_entry_continue_rcu(elem, head, list) {
 		if (hook_thresh > elem->priority)
 			continue;
 
@@ -155,11 +154,14 @@ repeat:
 				continue;
 			}
 #endif
-			if (verdict != NF_REPEAT)
+			if (verdict != NF_REPEAT) {
+				*i = &elem->list;
 				return verdict;
+			}
 			goto repeat;
 		}
 	}
+	*i = &elem->list;
 	return NF_ACCEPT;
 }
 
-- 
1.7.10.4


  parent reply	other threads:[~2012-08-23  0:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-22 23:38 [PATCH 00/10] netfilter updates for net-next (batch 1) pablo
2012-08-22 23:38 ` [PATCH 01/10] ipvs: ip_vs_ftp depends on nf_conntrack_ftp helper pablo
2012-08-22 23:38 ` [PATCH 02/10] ipvs: generalize app registration in netns pablo
2012-08-22 23:38 ` [PATCH 03/10] ipvs: fixed sparse warning pablo
2012-08-22 23:38 ` [PATCH 04/10] ipvs: implement passive PMTUD for IPIP packets pablo
2012-08-22 23:38 ` [PATCH 05/10] ipvs: add pmtu_disc option to disable IP DF for TUN packets pablo
2012-08-22 23:38 ` [PATCH 06/10] netfilter: PTR_RET can be used pablo
2012-08-22 23:38 ` [PATCH 07/10] netfilter: sparse endian fixes pablo
2012-08-22 23:38 ` [PATCH 08/10] netfilter: nf_conntrack: remove unnecessary RTNL locking pablo
2012-08-22 23:38 ` pablo [this message]
2012-08-22 23:38 ` [PATCH 10/10] netfilter: remove unnecessary goto statement for error recovery pablo
2012-08-23  2:10 ` [PATCH 00/10] netfilter updates for net-next (batch 1) David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345678726-3109-10-git-send-email-pablo@netfilter.org \
    --to=pablo@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).