netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: pablo@netfilter.org
To: netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: [PATCH 01/10] ipvs: ip_vs_ftp depends on nf_conntrack_ftp helper
Date: Thu, 23 Aug 2012 01:38:37 +0200	[thread overview]
Message-ID: <1345678726-3109-2-git-send-email-pablo@netfilter.org> (raw)
In-Reply-To: <1345678726-3109-1-git-send-email-pablo@netfilter.org>

From: Julian Anastasov <ja@ssi.bg>

	The FTP application indirectly depends on the
nf_conntrack_ftp helper for proper NAT support. If the
module is not loaded, IPVS can resize the packets for the
command connection, eg. PASV response but the SEQ adjustment
logic in ipv4_confirm is not called without helper.

Signed-off-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
 net/netfilter/ipvs/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/netfilter/ipvs/Kconfig b/net/netfilter/ipvs/Kconfig
index f987138..8b2cffd 100644
--- a/net/netfilter/ipvs/Kconfig
+++ b/net/netfilter/ipvs/Kconfig
@@ -250,7 +250,8 @@ comment 'IPVS application helper'
 
 config	IP_VS_FTP
   	tristate "FTP protocol helper"
-        depends on IP_VS_PROTO_TCP && NF_CONNTRACK && NF_NAT
+	depends on IP_VS_PROTO_TCP && NF_CONNTRACK && NF_NAT && \
+		NF_CONNTRACK_FTP
 	select IP_VS_NFCT
 	---help---
 	  FTP is a protocol that transfers IP address and/or port number in
-- 
1.7.10.4


  reply	other threads:[~2012-08-23  0:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-22 23:38 [PATCH 00/10] netfilter updates for net-next (batch 1) pablo
2012-08-22 23:38 ` pablo [this message]
2012-08-22 23:38 ` [PATCH 02/10] ipvs: generalize app registration in netns pablo
2012-08-22 23:38 ` [PATCH 03/10] ipvs: fixed sparse warning pablo
2012-08-22 23:38 ` [PATCH 04/10] ipvs: implement passive PMTUD for IPIP packets pablo
2012-08-22 23:38 ` [PATCH 05/10] ipvs: add pmtu_disc option to disable IP DF for TUN packets pablo
2012-08-22 23:38 ` [PATCH 06/10] netfilter: PTR_RET can be used pablo
2012-08-22 23:38 ` [PATCH 07/10] netfilter: sparse endian fixes pablo
2012-08-22 23:38 ` [PATCH 08/10] netfilter: nf_conntrack: remove unnecessary RTNL locking pablo
2012-08-22 23:38 ` [PATCH 09/10] netfilter: replace list_for_each_continue_rcu with new interface pablo
2012-08-22 23:38 ` [PATCH 10/10] netfilter: remove unnecessary goto statement for error recovery pablo
2012-08-23  2:10 ` [PATCH 00/10] netfilter updates for net-next (batch 1) David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345678726-3109-2-git-send-email-pablo@netfilter.org \
    --to=pablo@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).